Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid printing getFTLConfigValue return in statusFunc() #5442

Merged
merged 1 commit into from
Oct 18, 2023

Conversation

rdwebdesign
Copy link
Member

What does this PR aim to accomplish?

pihole status is printing the string true, but it shouldn't.

pidev:/# pihole status
  [✓] FTL is listening on port 53
     [✓] UDP (IPv4)
     [✓] TCP (IPv4)
     [✓] UDP (IPv6)
     [✓] TCP (IPv6)

true
  [✓] Pi-hole blocking is enabled

This value is generated when function getFTLConfigValue dns.blocking.active executes pihole-FTL --config -q dns.blocking.active.

The pihole-FTL return is true and the value is printed.

Note:
it happens at least inside Alpine container. Not sure about bare metal install.

How does this PR accomplish the above?

Storing the return in a variable avoids the printing.

Link documentation PRs if any are needed to support this PR:

none


By submitting this pull request, I confirm the following:

  1. I have read and understood the contributors guide, as well as this entire template. I understand which branch to base my commits and Pull Requests against.
  2. I have commented my proposed changes within the code and I have tested my changes.
  3. I am willing to help maintain this change if there are issues with it later.
  4. It is compatible with the EUPL 1.2 license
  5. I have squashed any insignificant commits. (git rebase)
  6. I have checked that another pull request for this purpose does not exist.
  7. I have considered, and confirmed that this submission will be valuable to others.
  8. I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
  9. I give this submission freely, and claim no ownership to its content.

  • I have read the above and my PR is ready for review. Check this box to confirm

Signed-off-by: RD WebDesign <github@rdwebdesign.com.br>
@rdwebdesign rdwebdesign requested a review from a team October 18, 2023 05:14
@yubiuser
Copy link
Member

It happens on bare metal too

nanopi@nanopi:~$ pihole status
  [✓] FTL is listening on port 53
     [✓] UDP (IPv4)
     [✓] TCP (IPv4)
     [✓] UDP (IPv6)
     [✓] TCP (IPv6)

true
  [✓] Pi-hole blocking is enabled

@yubiuser yubiuser merged commit 2deadb2 into development-v6 Oct 18, 2023
14 checks passed
@yubiuser yubiuser deleted the tweak/statusFunc branch October 18, 2023 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants