-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
*BREAKING* Drop support for ancient ARMv4 and ARMv5 #5445
Conversation
…t to cause unresolvable SIGFPE on ARMv6 and lower. Fortunately, we can still use the Alpine binaries on all Raspberry Pi models (even the oldest ones) Signed-off-by: DL6ER <dl6er@dl6er.de>
cc97e35
to
c571d8d
Compare
Does this mean, we can also drop the Debian based build image? |
Yes, we can drop https://github.com/pi-hole/docker-base-images/tree/master/ftl-build/debian (and move But this would be the first step and would need to be merged first before the others can land. It simplifies quite a few things! |
Maybe we should rename the title as it is not that drastic
To something like |
This pull request has been mentioned on Pi-hole Userspace. There might be relevant details there: https://discourse.pi-hole.net/t/failure-to-create-gravity-floating-point-error/65705/19 |
This pull request has been mentioned on Pi-hole Userspace. There might be relevant details there: https://discourse.pi-hole.net/t/beta6-fails-on-rpi2-on-bookworm-detected-as-arm6/65625/12 |
Hm tried it on my Zero W (which should be ArmV6) and seems like the detection is off. At least now install fails with "this architecture is not supported" anymore.
|
Thanks for the report! This was due to a glitch and should be fixed by #5451 |
This pull request has been mentioned on Pi-hole Userspace. There might be relevant details there: https://discourse.pi-hole.net/t/pi-hole-beta-6-0-on-pogoplug-pro/70643/5 |
What does this implement/fix?
Drop support for ancient ARMv4 and ARMv5, the Debian binaries turn out to cause unsolvable SIGFPE on ARMv6 and lower. Fortunately, we can still use the Alpine binaries on all Raspberry Pi models (even the oldest ones). Use them on ARMv6 devices to restore compatibility of Pi-hole with the very early boards like Raspberry Pi 1B and Zero (W).
Both feature a
BCM2835
chip which is a member of the ARM11 family (typeARM1176JZF-S
) which turns out to be thearmv6KZ
architecture so exactly whatalpine/arm/v6
is designed for.Related issue or feature (if applicable): https://discourse.pi-hole.net/t/failure-to-create-gravity-floating-point-error/65705
Pull request in docs with documentation (if applicable): to be checked
By submitting this pull request, I confirm the following:
git rebase
)Checklist:
developmental
branch.