Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Start counting at postion 1 #5470

Merged
merged 1 commit into from
Nov 2, 2023
Merged

Start counting at postion 1 #5470

merged 1 commit into from
Nov 2, 2023

Conversation

yubiuser
Copy link
Member

@yubiuser yubiuser commented Nov 1, 2023

What does this PR aim to accomplish?:

A long forgotten branch adapted to v6.
awk's substr starts counting at position 1, not zero (see https://www.gnu.org/software/gawk/manual/html_node/String-Functions.html#index-substr_0028_0029-function). There is no change in output, but this is the correct way of doing things.

nanopi@nanopi:~$ git ls-remote "https://github.com/pi-hole/pi-hole" --tags development | awk '{print substr($0, 0,8);}'
300a4e22
nanopi@nanopi:~$ git ls-remote "https://github.com/pi-hole/pi-hole" --tags development | awk '{print substr($0, 1,8);}'
300a4e22

By submitting this pull request, I confirm the following:

  1. I have read and understood the contributors guide, as well as this entire template. I understand which branch to base my commits and Pull Requests against.
  2. I have commented my proposed changes within the code and I have tested my changes.
  3. I am willing to help maintain this change if there are issues with it later.
  4. It is compatible with the EUPL 1.2 license
  5. I have squashed any insignificant commits. (git rebase)
  6. I have checked that another pull request for this purpose does not exist.
  7. I have considered, and confirmed that this submission will be valuable to others.
  8. I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
  9. I give this submission freely, and claim no ownership to its content.

  • I have read the above and my PR is ready for review. Check this box to confirm

Signed-off-by: Christian König <ckoenig@posteo.de>
@yubiuser yubiuser requested a review from a team November 1, 2023 21:01
@yubiuser yubiuser merged commit 4c129af into development-v6 Nov 2, 2023
15 checks passed
@yubiuser yubiuser deleted the awk branch November 2, 2023 06:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants