Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove local.list and openVPN traces #5480

Merged
merged 1 commit into from
Feb 10, 2024
Merged

Remove local.list and openVPN traces #5480

merged 1 commit into from
Feb 10, 2024

Conversation

yubiuser
Copy link
Member

@yubiuser yubiuser commented Nov 6, 2023

What does this PR aim to accomplish?:

Remove /etc/pihole/local.list.
As far as I understood, it has been used previously (before local dns records) existed for additional local hosts. One use was to import openVPN hosts. As we don't do such a hand-holding for other VPN services, I think it's time to go.


By submitting this pull request, I confirm the following:

  1. I have read and understood the contributors guide, as well as this entire template. I understand which branch to base my commits and Pull Requests against.
  2. I have commented my proposed changes within the code and I have tested my changes.
  3. I am willing to help maintain this change if there are issues with it later.
  4. It is compatible with the EUPL 1.2 license
  5. I have squashed any insignificant commits. (git rebase)
  6. I have checked that another pull request for this purpose does not exist.
  7. I have considered, and confirmed that this submission will be valuable to others.
  8. I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
  9. I give this submission freely, and claim no ownership to its content.

  • I have read the above and my PR is ready for review. Check this box to confirm

Signed-off-by: Christian König <ckoenig@posteo.de>
@yubiuser yubiuser requested a review from a team November 6, 2023 20:46
@dschaper
Copy link
Member

dschaper commented Nov 7, 2023

@jfb-pihole Do you (or Buck) still advise people to use this file?

@PromoFaux
Copy link
Member

paging @jfb-pihole @Bucking-Horn for comment

@Bucking-Horn
Copy link

I think I've stopped referring local.list after pihole-FTL introduced automatic handling of pi.hole with Pi-hole FTL v5.9 in 2021.

@yubiuser
Copy link
Member Author

yubiuser commented Feb 9, 2024

The corresponding FTL PR has been merged pi-hole/FTL#1752

@yubiuser yubiuser merged commit aca7b31 into development-v6 Feb 10, 2024
14 checks passed
@yubiuser yubiuser deleted the no_openVPN branch February 10, 2024 05:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants