Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop Fedora 36 and add Fedora 39 to the test suite #5482

Merged
merged 2 commits into from
Jan 29, 2024

Conversation

yubiuser
Copy link
Member

@yubiuser yubiuser commented Nov 7, 2023

What does this PR aim to accomplish?:

Fedora 36 is EOL since May 2023 and today they shut down the metadata for repository for 'fedora-modular'. Our test suite will therefor always fail.
Fedora 39 was released today.


By submitting this pull request, I confirm the following:

  1. I have read and understood the contributors guide, as well as this entire template. I understand which branch to base my commits and Pull Requests against.
  2. I have commented my proposed changes within the code and I have tested my changes.
  3. I am willing to help maintain this change if there are issues with it later.
  4. It is compatible with the EUPL 1.2 license
  5. I have squashed any insignificant commits. (git rebase)
  6. I have checked that another pull request for this purpose does not exist.
  7. I have considered, and confirmed that this submission will be valuable to others.
  8. I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
  9. I give this submission freely, and claim no ownership to its content.

  • I have read the above and my PR is ready for review. Check this box to confirm

Signed-off-by: Christian König <ckoenig@posteo.de>
@yubiuser
Copy link
Member Author

yubiuser commented Nov 7, 2023

Tests will fail until someone with write access adds Fedora 39 to dev_supporedos.yaml

@yubiuser
Copy link
Member Author

@pi-hole/core-maintainers

Fedora 36 tests are failing again for various core PRs. Any opinions about this PR?

@pralor-bot
Copy link

This pull request has been mentioned on Pi-hole Userspace. There might be relevant details there:

https://discourse.pi-hole.net/t/v6-beta-qol-improvements/67308/2

@PromoFaux
Copy link
Member

Fedora 37 now EOL, too. Do you want to address that in this PR? I'll update the dev TXT record

Signed-off-by: Christian König <ckoenig@posteo.de>
@yubiuser
Copy link
Member Author

I also removed Fedora 37

@yubiuser
Copy link
Member Author

Doc PR: pi-hole/docs#989

@PromoFaux PromoFaux merged commit 9a3affd into development-v6 Jan 29, 2024
14 checks passed
@PromoFaux PromoFaux deleted the fedora_update branch January 29, 2024 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants