Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "-ni" to all sqlite3 invocations #5518

Merged
merged 1 commit into from
Dec 10, 2023
Merged

Add "-ni" to all sqlite3 invocations #5518

merged 1 commit into from
Dec 10, 2023

Conversation

DL6ER
Copy link
Member

@DL6ER DL6ER commented Dec 9, 2023

What does this implement/fix?

This PR fixes #4650 for Pi-hole v6.0 by adding -ni to all pihole-FTL sqlite3 invocations. This PR was created fully-automatically using search-and-replace like

Screenshot from 2023-12-09 23-04-36
Screenshot from 2023-12-09 23-04-52


Related issue or feature (if applicable): N/A

Pull request in docs with documentation (if applicable): N/A


By submitting this pull request, I confirm the following:

  1. I have read and understood the contributors guide, as well as this entire template. I understand which branch to base my commits and Pull Requests against.
  2. I have commented my proposed changes within the code.
  3. I am willing to help maintain this change if there are issues with it later.
  4. It is compatible with the EUPL 1.2 license
  5. I have squashed any insignificant commits. (git rebase)

Checklist:

  • The code change is tested and works locally.
  • I based my code and PRs against the repositories developmental branch.
  • I signed off all commits. Pi-hole enforces the DCO for all contributions
  • I signed all my commits. Pi-hole requires signatures to verify authorship
  • I have read the above and my PR is ready for review.

Signed-off-by: DL6ER <dl6er@dl6er.de>
@DL6ER DL6ER added Bug: fixed Contains a bug resolution Pi-hole v6.0 labels Dec 9, 2023
@pralor-bot
Copy link

This pull request has been mentioned on Pi-hole Userspace. There might be relevant details there:

https://discourse.pi-hole.net/t/all-adlist-connections-refused-no-cached-lists-available/66840/28

@yubiuser
Copy link
Member

yubiuser commented Dec 9, 2023

Errors at

sqlite3: Error: unknown option: -ni

@DL6ER
Copy link
Member Author

DL6ER commented Dec 9, 2023

Are you using the latest development-v6 binaries?

edit The binary builds are not yet finished, i.e., the binaries are not yet updated.

@yubiuser
Copy link
Member

yubiuser commented Dec 9, 2023

The CI tests complain.

@pralor-bot
Copy link

This pull request has been mentioned on Pi-hole Userspace. There might be relevant details there:

https://discourse.pi-hole.net/t/all-adlist-connections-refused-no-cached-lists-available/66840/31

@DL6ER
Copy link
Member Author

DL6ER commented Dec 10, 2023

Binary build have finished, tests succeeded

Copy link
Member

@yubiuser yubiuser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Before

*** [ DIAGNOSING ]: Name resolution (IPv4) using a random blocked domain and a known ad-serving domain
-- Loading resources from /root/.sqliterc
[✗] Failed to resolve domain
bob430.web3000.com on lo (127.0.0.1)
[✗] Failed to resolve domain
bob430.web3000.com on end0 (10.0.1.24)
[✓] No IPv4 address available on wlan0
[✓] doubleclick.com is 142.251.36.206 via a remote, public DNS server (8.8.8.8)

*** [ DIAGNOSING ]: Name resolution (IPv6) using a random blocked domain and a known ad-serving domain
-- Loading resources from /root/.sqliterc
[✗] Failed to resolve domain
bob829.web3000.com on lo (::1)
[✗] Failed to resolve domain
bob829.web3000.com on end0 (fe80::dd1b:451d:132:4316)
[✓] No IPv6 address available on wlan0
[✗] Failed to resolve doubleclick.com via a remote, public DNS server (2001:4860:4860::8888)

After

*** [ DIAGNOSING ]: Name resolution (IPv4) using a random blocked domain and a known ad-serving domain
[✓] tracking.hittail.com is NOERROR on lo (127.0.0.1)
[✓] tracking.hittail.com is NOERROR on end0 (10.0.1.24)
[✓] No IPv4 address available on wlan0
[✓] doubleclick.com is 142.251.36.206 via a remote, public DNS server (8.8.8.8)

*** [ DIAGNOSING ]: Name resolution (IPv6) using a random blocked domain and a known ad-serving domain
[✓] marketing.visitvancouverusa.com is NOERROR on lo (::1)
[✗] Failed to resolve marketing.visitvancouverusa.com on end0 (fe80::dd1b:451d:132:4316)
[✓] No IPv6 address available on wlan0
[✗] Failed to resolve doubleclick.com via a remote, public DNS server (2001:4860:4860::8888)

@DL6ER DL6ER merged commit 719ce80 into development-v6 Dec 10, 2023
14 checks passed
@DL6ER DL6ER deleted the new/sql_ni branch December 10, 2023 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug: fixed Contains a bug resolution Pi-hole v6.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants