Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Highlight "### CHANGED" strings in the debug log of pihole.toml #5601

Merged
merged 1 commit into from
Mar 9, 2024

Conversation

DL6ER
Copy link
Member

@DL6ER DL6ER commented Mar 9, 2024

What does this implement/fix?

See title, example:

Screenshot from 2024-03-09 11-14-12

Related issue or feature (if applicable): N/A

Pull request in docs with documentation (if applicable): N/A


By submitting this pull request, I confirm the following:

  1. I have read and understood the contributors guide, as well as this entire template. I understand which branch to base my commits and Pull Requests against.
  2. I have commented my proposed changes within the code.
  3. I am willing to help maintain this change if there are issues with it later.
  4. It is compatible with the EUPL 1.2 license
  5. I have squashed any insignificant commits. (git rebase)

Checklist:

  • The code change is tested and works locally.
  • I based my code and PRs against the repositories developmental branch.
  • I signed off all commits. Pi-hole enforces the DCO for all contributions
  • I signed all my commits. Pi-hole requires signatures to verify authorship
  • I have read the above and my PR is ready for review.

@DL6ER DL6ER requested a review from a team March 9, 2024 10:18
Copy link
Member

@yubiuser yubiuser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At some point, we may want to check the file line-by-line, so that's the reason for an array

As you decided to remove this possibility, you can remove all the leftovers from file_content

@DL6ER
Copy link
Member Author

DL6ER commented Mar 9, 2024

@yubiuser I addressed your comment

@DL6ER DL6ER merged commit dedaf54 into development-v6 Mar 9, 2024
14 checks passed
@DL6ER DL6ER deleted the tweak/colorful_debug branch March 9, 2024 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants