Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve changed binary message during update process #5621

Merged
merged 1 commit into from
Mar 28, 2024

Conversation

DL6ER
Copy link
Member

@DL6ER DL6ER commented Mar 28, 2024

What does this implement/fix?

Non-matching checksums are not always corruption. Actually, they will instead be caused by binaries updated on the remote branch. This is most seen with frequently changing branches such as development-v6 at this time.

This was recently been made worse in PR #5603 where code duplication has been reduced: before we had different messages for master and custom branches - now there is only one.


Related issue or feature (if applicable): N/A

Pull request in docs with documentation (if applicable): N/A


By submitting this pull request, I confirm the following:

  1. I have read and understood the contributors guide, as well as this entire template. I understand which branch to base my commits and Pull Requests against.
  2. I have commented my proposed changes within the code.
  3. I am willing to help maintain this change if there are issues with it later.
  4. It is compatible with the EUPL 1.2 license
  5. I have squashed any insignificant commits. (git rebase)

Checklist:

  • The code change is tested and works locally.
  • I based my code and PRs against the repositories developmental branch.
  • I signed off all commits. Pi-hole enforces the DCO for all contributions
  • I signed all my commits. Pi-hole requires signatures to verify authorship
  • I have read the above and my PR is ready for review.

… instead be caused by binaries updated on the remote branch. This is most seen with frequently channging branchs such as development-v6 at this time.

Signed-off-by: DL6ER <dl6er@dl6er.de>
@DL6ER DL6ER requested a review from a team March 28, 2024 08:19
@pralor-bot
Copy link

This pull request has been mentioned on Pi-hole Userspace. There might be relevant details there:

https://discourse.pi-hole.net/t/beta-6-pihole-up-showing-image-corruption/69183/18

@DL6ER DL6ER merged commit c7d6029 into development-v6 Mar 28, 2024
13 checks passed
@DL6ER DL6ER deleted the fix/corruption_msg branch March 28, 2024 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants