[WIP] Store all gravity whitelist and blacklist vars in pihole

[tuplink]

By submitting this pull request, I confirm the following (please check boxes, eg [X]):

• I have read and understood the contributors guide.
• I have checked that another pull request for this purpose does not exist.
• I have considered, and confirmed that this submission will be valuable to others.
• I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
• I give this submission freely, and claim no ownership to its content.

How familiar are you with the codebase?:

• 1 (very unfamiliar)
• 2
• 3
• 4
• 5
• 6
• 7
• 8
• 9
• 10 (very familiar)

---

Store all script vars in pihole

[dschaper]

These need to be in the format of "${blacklistFile}" so that bash doesn't split on space if the filename contains a space.

[tuplink]

good catch

[tuplink]

that mistake is all over

[dschaper]

Yeah, you're cleaning up a lot of our messes that we needed to get to, so thank you thank you for that!!

[dschaper]

I believe exporting all of these variables and values will leave them in the environment even after the script is finished executing. I'll need to check on that however.

[tuplink]

pihole -w zzz.clickbank.net > /dev/null ; echo "basename=$basename"

basename=

[dschaper]

What's the env look like?

[tuplink]

probably better to just ignore this one till a few are taken care of first cause i imagin its going to get lots of conflicts

[dschaper]

There's two ways you can put a hold on a merge, you can tag/label WIP for Work In Progress, or I believe we have it set so that the PR author needs to approve the merge before PullApprove will release it...

[tuplink]

or i just remove the branch?

[dschaper]

So far there are no conflicts, so I wouldn't close out the PR...

[tuplink]

gonna any ways alot of quotes need fixed 👍

[tuplink]

export command is used to export a variable or function to the environment of all the child processes running in the current shell.

[tuplink]

So only processes spawned from where its called

[dschaper]

Okay cool, good to know.

[AzureMarker]

@tuplink @pi-hole/gravity Is this now obsolete with #859?

[tuplink]

@Mcat12 mostly

basename=pihole
piholeDir=/etc/${basename}
whitelist=${piholeDir}/whitelist.txt
blacklist=${piholeDir}/blacklist.txt

would be moved to setupVars and setupVars would be sourced from all scripts

and basic-install would need to reflect the changes to setupvars

[AzureMarker]

And the web interface php files would need to take their paths from setupVars

[tuplink]

Haven't looked into that. Should probably build that into pihole script For the list. And use the pihole command to edit

[AzureMarker]

The web interface already uses the pihole command to edit the lists, but other files are hardcoded, for example gravity.list and the whitelist/blacklist files.

[tuplink]

so,
TODO part 1:
blacklist.sh
FIX output of pihole -b -l (outputs lots of extra stuff)
whitelist.sh
FIX output of pihole -w -l (outputs lots of extra stuff)
ADMIN-LTE
make use of "pihole -b -l" and "pihole -w -l"

TODO part 2
move gravity whitelist and blacklist vars to setupVars

[AzureMarker]

I would start a whole new branch using the latest code, which has the white and black lists in list.sh

[tuplink]

will start on this monday