Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[test] Screen detection, sane minimums for whiptail dailogs #860

Merged
merged 3 commits into from Oct 26, 2016

Conversation

brontide
Copy link
Contributor

This template was created based on the work of udemy-dl.

By submitting this pull request, I confirm the following (please check boxes, eg [X]):

  • I have read and understood the contributors guide.
  • I have checked that another pull request for this purpose does not exist.
  • I have considered, and confirmed that this submission will be valuable to others.
  • I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
  • I give this submission freely, and claim no ownership to its content.

How familiar are you with the codebase?:

  • 1 (very unfamiliar)
  • 2
  • 3
  • 4
  • 5
  • 6
  • 7
  • 8
  • 9
  • 10 (very familiar)

I cherry-picked the screen detection from my alpine branch since it's an easy fix.

@PromoFaux
Copy link
Member

PromoFaux commented Oct 26, 2016

Approved

Approved with PullApprove

@PromoFaux PromoFaux added the PR: Code Review Required Open Pull Request, needs code reviewd label Oct 26, 2016
@dschaper
Copy link
Member

dschaper commented Oct 26, 2016

Approved

Approved with PullApprove

@dschaper
Copy link
Member

👍

@dschaper dschaper merged commit 7c89b69 into pi-hole:development Oct 26, 2016
@brontide brontide deleted the screen_detection branch October 26, 2016 18:07
@dschaper dschaper removed the PR: Code Review Required Open Pull Request, needs code reviewd label May 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants