Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A man has no name. Even though his name is Jaqen H'ghar #985

Merged
merged 6 commits into from Dec 15, 2016

Conversation

PromoFaux
Copy link
Member

This template was created based on the work of udemy-dl.

By submitting this pull request, I confirm the following (please check boxes, eg [X]):

  • I have read and understood the contributors guide.
  • I have checked that another pull request for this purpose does not exist.
  • I have considered, and confirmed that this submission will be valuable to others.
  • I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
  • I give this submission freely, and claim no ownership to its content.

How familiar are you with the codebase?:

  • 10 (very familiar)

Re-addresses #849

Stops random ad domain being returned when user pings a domain that is included in gravity.list. Instead, the devices hostname is returned.

Also include pi.hole in the additional additional hosts file.

@PromoFaux PromoFaux added PR: Approval Required Open Pull Request, needs approval PR: Code Review Required Open Pull Request, needs code reviewd labels Dec 14, 2016
@DL6ER
Copy link
Member

DL6ER commented Dec 14, 2016

Succesfully tested on IPv4 only system

@AzureMarker
Copy link
Contributor

AzureMarker commented Dec 15, 2016

Approved. Tested on DO droplet.

Approved with PullApprove

@PromoFaux PromoFaux merged commit 4348653 into development Dec 15, 2016
@PromoFaux PromoFaux deleted the pi.hole branch December 15, 2016 08:49
@dschaper dschaper removed PR: Approval Required Open Pull Request, needs approval PR: Code Review Required Open Pull Request, needs code reviewd labels May 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants