Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No visual indicators of side menu items keyboard focus #1843

Closed
ghost opened this issue Jul 3, 2021 · 1 comment · Fixed by #1955
Closed

No visual indicators of side menu items keyboard focus #1843

ghost opened this issue Jul 3, 2021 · 1 comment · Fixed by #1955
Labels
Fixed In Next Release

Comments

@ghost
Copy link

ghost commented Jul 3, 2021

Versions

  • Pi-hole: v5.3.1
  • AdminLTE: v5.5
  • FTL: v5.8.1

Platform

  • OS and version: Ubuntu 20.04.2 LTS
  • Platform: (GNU/Linux 5.4.106-1-pve x86_64)

Expected behavior

When navigating the admin app with the keyboard, the side menus items should be highlighted, when they are focused

Actual behavior / bug

There is no visual indication whatsoever that a menu item is focused

Steps to reproduce

  1. Open the admin panel (you might have to login, but it is already reproducable bevore)
  2. Press tab an your keyboard
  3. Notice how there is no focus indicator on the side menus items
@rdwebdesign rdwebdesign mentioned this issue Oct 30, 2021
Merged
9 tasks
@yubiuser yubiuser linked a pull request Nov 1, 2021 that will close this issue
Sidebar and nav-tab-custom: additional CSS for focus state #1955
Merged
9 tasks
@yubiuser yubiuser closed this as completed Jan 1, 2022
@rdwebdesign
Copy link
Member

Fixed by #1955

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Fixed In Next Release
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Sidebar and nav-tab-custom: additional CSS for focus state
2 participants
@rdwebdesign @yubiuser