Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for international domain names #1130

Merged
merged 2 commits into from Feb 4, 2020
Merged

Conversation

DL6ER
Copy link
Member

@DL6ER DL6ER commented Jan 12, 2020

By submitting this pull request, I confirm the following:

  • I have read and understood the contributors guide, as well as this entire template.
  • I have made only one major change in my proposed changes.
  • I have commented my proposed changes within the code.
  • I have tested my proposed changes, and have included unit tests where possible.
  • I am willing to help maintain this change if there are issues with it later.
  • I give this submission freely and claim no ownership.
  • It is compatible with the EUPL 1.2 license
  • I have squashed any insignificant commits. (git rebase)

What does this PR aim to accomplish?:

Add support for international domain names.

How does this PR accomplish the above?:

Convert domains to IDN form (if applicable) before adding them to the database.
Note that this relies on php-intl to be installed, I will add it in a separate PR to the core repo.

Traditional domains list
Screenshot from 2020-01-12 13-56-47

Group management domains page
Screenshot from 2020-01-12 13-56-32

What documentation changes (if any) are needed to support this PR?:

None

…php-intl to be installed

Signed-off-by: DL6ER <dl6er@dl6er.de>
@DL6ER DL6ER added this to the v5.0 milestone Jan 12, 2020
@DL6ER DL6ER requested a review from a team January 12, 2020 12:58
@pralor-bot
Copy link

This pull request has been mentioned on Pi-hole Userspace. There might be relevant details there:

https://discourse.pi-hole.net/t/url-allestorungen/26659/19

@DL6ER
Copy link
Member Author

DL6ER commented Jan 12, 2020

For those who want to test it but don't have Umlauts on their keyboards, you can copy&paste the test domains from below:

allestörungen.de
testäää.de

@DL6ER
Copy link
Member Author

DL6ER commented Jan 13, 2020

The necessary core PR has been merged.

@DL6ER DL6ER changed the base branch from devel to release/v5.0 January 13, 2020 16:28
@DL6ER
Copy link
Member Author

DL6ER commented Feb 4, 2020

This may be reviewed and merged at any time.

@dschaper
Copy link
Member

dschaper commented Feb 4, 2020

Does this require the v2 build containers or the libidn things?

@DL6ER
Copy link
Member Author

DL6ER commented Feb 4, 2020

No, it's only using PHP stuff which we already added in pi-hole/pi-hole#3076

@DL6ER DL6ER merged commit 2860ce3 into release/v5.0 Feb 4, 2020
@DL6ER DL6ER deleted the new/intl_domains branch February 4, 2020 20:07
@pralor-bot
Copy link

This pull request has been mentioned on Pi-hole Userspace. There might be relevant details there:

https://discourse.pi-hole.net/t/database-error-after-update/27966/6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants