Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure we refresh FTL's internal groups cache. #1142

Merged
merged 2 commits into from Feb 3, 2020

Conversation

DL6ER
Copy link
Member

@DL6ER DL6ER commented Jan 27, 2020

By submitting this pull request, I confirm the following:

  • I have read and understood the contributors guide, as well as this entire template.
  • I have made only one major change in my proposed changes.
  • I have commented my proposed changes within the code.
  • I have tested my proposed changes, and have included unit tests where possible.
  • I am willing to help maintain this change if there are issues with it later.
  • I give this submission freely and claim no ownership.
  • It is compatible with the EUPL 1.2 license
  • I have squashed any insignificant commits. (git rebase)

What does this PR aim to accomplish?:

Fix a bug mentioned on Discourse.

How does this PR accomplish the above?:

Ensure we reach the end of groups.php to send SIGRTMIN to FTL by not returning too early.

What documentation changes (if any) are needed to support this PR?:

None

@DL6ER DL6ER added the Bugfix label Jan 27, 2020
@DL6ER DL6ER added this to the v5.0 milestone Jan 27, 2020
@DL6ER DL6ER requested a review from a team January 27, 2020 12:43
@pralor-bot
Copy link

This pull request has been mentioned on Pi-hole Userspace. There might be relevant details there:

https://discourse.pi-hole.net/t/changes-to-group-management-dont-purge-ftl-cache/27507/3

@pralor-bot
Copy link

This pull request has been mentioned on Pi-hole Userspace. There might be relevant details there:

https://discourse.pi-hole.net/t/disable-pihole-with-group-management/27407/11

@PromoFaux PromoFaux merged commit 4958ed2 into release/v5.0 Feb 3, 2020
@PromoFaux PromoFaux deleted the fix/FTL_group_update branch February 3, 2020 22:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants