Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix computation of percentages in the over-time graph #1146

Merged
merged 1 commit into from Feb 7, 2020

Conversation

DL6ER
Copy link
Member

@DL6ER DL6ER commented Feb 4, 2020

By submitting this pull request, I confirm the following:

  • I have read and understood the contributors guide, as well as this entire template.
  • I have made only one major change in my proposed changes.
  • I have commented my proposed changes within the code.
  • I have tested my proposed changes, and have included unit tests where possible.
  • I am willing to help maintain this change if there are issues with it later.
  • I give this submission freely and claim no ownership.
  • It is compatible with the EUPL 1.2 license
  • I have squashed any insignificant commits. (git rebase)

What does this PR aim to accomplish?:

Fix computation of percentages in the over-time graph

How does this PR accomplish the above?:

Fix ratio to be computed against number of total, not permitted queries.

What documentation changes (if any) are needed to support this PR?:

None

Signed-off-by: DL6ER <dl6er@dl6er.de>
@DL6ER DL6ER added the Bugfix label Feb 4, 2020
@DL6ER DL6ER added this to the v5.0 milestone Feb 4, 2020
@DL6ER DL6ER requested a review from a team February 4, 2020 21:41
@pralor-bot
Copy link

This pull request has been mentioned on Pi-hole Userspace. There might be relevant details there:

https://discourse.pi-hole.net/t/cosmetic-issues-on-web-ui/27715/2

@DL6ER DL6ER merged commit 4333931 into release/v5.0 Feb 7, 2020
@DL6ER DL6ER deleted the fix/percentages branch February 7, 2020 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants