Changed $domains_being_blocked to point to gravity.list, instead of a… #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… file that no longer exists.
Divide gravity.list count by 2, as each domain has both IPv4 and IPv6.
divide count from gravity.list by two, as each domain has both IPv4 and IPv6
|
Does this take into account whether or not the user is using ipv6? If they aren't, it will show them as blocking half as many as they actually are. |
|
Very good point. No, it was just a simple line change... perhaps |
|
You know what, scratch this. I think it's probably better to put the count in a seperate file that is worked out after the gravity.list is generated, so that we can take into account white and blacklisted domains. Ignore everything! also gives an opportunity for the leftover files to be cleared down once |
|
This will work as a stopgap until I or someone else codes what I wrote in the above comment! |
This was referenced Jan 18, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #11
See:
pi-hole/pi-hole#191 (comment)