Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove an error log output that was presumably leftover from debugging #1326

Merged
merged 2 commits into from May 25, 2020

Conversation

PromoFaux
Copy link
Member

By submitting this pull request, I confirm the following:

  • I have read and understood the contributors guide, as well as this entire template.
  • I have made only one major change in my proposed changes.
  • I have commented my proposed changes within the code.
  • I have tested my proposed changes, and have included unit tests where possible.
  • I am willing to help maintain this change if there are issues with it later.
  • I give this submission freely and claim no ownership.
  • It is compatible with the EUPL 1.2 license
  • I have squashed any insignificant commits. (git rebase)

What does this PR aim to accomplish?:

With this line, this gets printed to the error log every time the page is loaded, looks to just be debug output, I might be wrong!

2020-05-18 16:57:14: (mod_fastcgi.c.421) FastCGI-stderr: Array
2020-05-18 16:57:14: (mod_fastcgi.c.421) FastCGI-stderr: (
2020-05-18 16:57:14: (mod_fastcgi.c.421) FastCGI-stderr:     [default-light2] => Array
2020-05-18 16:57:14: (mod_fastcgi.c.421) FastCGI-stderr:         (
2020-05-18 16:57:14: (mod_fastcgi.c.421) FastCGI-stderr:             [0] => Pi-hole default theme (light, default)
2020-05-18 16:57:14: (mod_fastcgi.c.421) FastCGI-stderr:             [1] =>
2020-05-18 16:57:14: (mod_fastcgi.c.421) FastCGI-stderr:             [2] => default-light
2020-05-18 16:57:14: (mod_fastcgi.c.421) FastCGI-stderr:             [3] => minimal
2020-05-18 16:57:14: (mod_fastcgi.c.421) FastCGI-stderr:             [4] => blue
2020-05-18 16:57:14: (mod_fastcgi.c.421) FastCGI-stderr:         )
2020-05-18 16:57:14: (mod_fastcgi.c.421) FastCGI-stderr:     [default-dark] => Array
2020-05-18 16:57:14: (mod_fastcgi.c.421) FastCGI-stderr:         (
2020-05-18 16:57:14: (mod_fastcgi.c.421) FastCGI-stderr:             [0] => Pi-hole midnight theme (dark)
2020-05-18 16:57:14: (mod_fastcgi.c.421) FastCGI-stderr:             [1] => 1
2020-05-18 16:57:14: (mod_fastcgi.c.421) FastCGI-stderr:             [2] => default-dark
2020-05-18 16:57:14: (mod_fastcgi.c.421) FastCGI-stderr:             [3] => polaris
2020-05-18 16:57:14: (mod_fastcgi.c.421) FastCGI-stderr:             [4] => polaris
2020-05-18 16:57:14: (mod_fastcgi.c.421) FastCGI-stderr:         )
2020-05-18 16:57:14: (mod_fastcgi.c.421) FastCGI-stderr:     [default-dark2] => Array
2020-05-18 16:57:14: (mod_fastcgi.c.421) FastCGI-stderr:         (
2020-05-18 16:57:14: (mod_fastcgi.c.421) FastCGI-stderr:             [0] => Pi-hole afternoon theme (dark)
2020-05-18 16:57:14: (mod_fastcgi.c.421) FastCGI-stderr:             [1] => 1
2020-05-18 16:57:14: (mod_fastcgi.c.421) FastCGI-stderr:             [2] => default-dark
2020-05-18 16:57:14: (mod_fastcgi.c.421) FastCGI-stderr:             [3] => futurico
2020-05-18 16:57:14: (mod_fastcgi.c.421) FastCGI-stderr:             [4] => futurico
2020-05-18 16:57:14: (mod_fastcgi.c.421) FastCGI-stderr:         )
2020-05-18 16:57:14: (mod_fastcgi.c.421) FastCGI-stderr: )

Signed-off-by: Adam Warner <me@adamwarner.co.uk>
…the error log

Signed-off-by: Adam Warner <me@adamwarner.co.uk>
@DL6ER DL6ER merged commit 3bfef7b into devel May 25, 2020
@DL6ER DL6ER deleted the tweak/notAnError branch May 25, 2020 18:00
@pralor-bot
Copy link

This pull request has been mentioned on Pi-hole Userspace. There might be relevant details there:

https://discourse.pi-hole.net/t/feedback-for-allow-defining-clients-by-their-mac-address-host-name-and-networking-interface/32324/103

@PromoFaux PromoFaux mentioned this pull request Jul 5, 2020
@pralor-bot
Copy link

This pull request has been mentioned on Pi-hole Userspace. There might be relevant details there:

https://discourse.pi-hole.net/t/pi-hole-5-1-released/35577/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants