Remember last used sort column/direction on DHCP lease tables #1332
Conversation
All other tables should already do it. |
|
Shows what I know!
Question though, I notice you are doing this with the groups tables: stateSaveCallback: function (settings, data) {
// Store current state in client's local storage area
localStorage.setItem("groups-clients-table", JSON.stringify(data));
},Is that actually needed, and should I add it to the DHCP table in this PR? |
|
Yes, because that's the important bit: https://github.com/pi-hole/AdminLTE/blob/master/scripts/pi-hole/js/queries.js#L410-L425 |
|
It resets the page and search fields |
PromoFaux
force-pushed
the
tweak/dhcp_save_state
branch
from
a758394
to
35cf35c
Compare
|
OK, done that, also whilst I was in there, I did some tidying up. |
groups-adlists.php
Outdated
| @@ -73,7 +73,7 @@ | |||
| </div> | |||
| </div> | |||
|
|
|||
| <script src="scripts/pi-hole/js/groups-common.js"></script> | |||
| <script src="scripts/pi-hole/js/common-utilities.js"></script> | |||
There was a problem hiding this comment.
Err, I have this in #1346.
There was a problem hiding this comment.
Ha. utils is a better name.
|
I'd rather we merge first #1346 and then rebase this. |
|
Fine by me |
… direction/column Signed-off-by: Adam Warner <me@adamwarner.co.uk>
Signed-off-by: Adam Warner <me@adamwarner.co.uk>
XhmikosR
force-pushed
the
tweak/dhcp_save_state
branch
3 times, most recently
from
86b846f
to
0b2483b
Compare
Signed-off-by: Adam Warner <me@adamwarner.co.uk>
XhmikosR
force-pushed
the
tweak/dhcp_save_state
branch
from
0b2483b
to
3957e9e
Compare
|
OK, this appears to be working the same as it was before rebase. Just needs someone else to review it now |
|
@PromoFaux how about moving the duplicate code patch to a separate PR? There are more duplicated stuff I want to move to utils but I don't want to overlap with this PR 🙂 BTW I believe we could squash the first 2 patches into one? |
|
To be honest that seems like doing more work for the sake of keeping things "just so" Let's keep it in this PR. Also I'm not the biggest fan of rewriting history in git for the sake of minimising the number of commits. It's the destination that is important, not the journey. Regards your PR with the other deduplication that is fine, just rebase on this branch (or devel once this is merged) - as it will land, it just needs for someone else to approve and merge it. |
|
Well, to be fair they shouldn't be 2 patches in the first place 😛 Anyway, as you wish, I can rebase my PRs when needed. |
|
This pull request has been mentioned on Pi-hole Userspace. There might be relevant details there: https://discourse.pi-hole.net/t/dhcp-free-scrolling-between-lines/33747/5 |
I found one: Local DNS Records lacks it. |
|
This pull request has been mentioned on Pi-hole Userspace. There might be relevant details there: https://discourse.pi-hole.net/t/pi-hole-5-1-released/35577/1 |
By submitting this pull request, I confirm the following:
git rebase)What does this PR aim to accomplish?:
Reference here.
Remember the last used sort column/direction for the DHCP lease tables. Does what it says on the tin.
Is there any value in adding this flag to other datatables, do you think?