Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvement to readability of footer "update" command text #1797

Merged
merged 1 commit into from May 7, 2021
Merged

Improvement to readability of footer "update" command text #1797

merged 1 commit into from May 7, 2021

Conversation

esqew
Copy link
Contributor

@esqew esqew commented May 6, 2021

Signed-off-by: Sean F Quinn sean@esqew.com

By submitting this pull request, I confirm the following:

  • I have read and understood the contributors guide, as well as this entire template.
  • I have made only one major change in my proposed changes.
  • I have commented my proposed changes within the code.
  • I have tested my proposed changes.
  • I am willing to help maintain this change if there are issues with it later.
  • I give this submission freely and claim no ownership.
  • It is compatible with the EUPL 1.2 license
  • I have squashed any insignificant commits. (git rebase)
  • I have Signed Off all commits. (git commit --signoff)

What does this PR aim to accomplish?:
Fix for #1796 (readability and standardization for the Pi-Hole update command in the interface)

How does this PR accomplish the above?:
Wrapped the command text in a <code></code> element.
image

What documentation changes (if any) are needed to support this PR?:
None!

Signed-off-by: Sean F Quinn <sean@esqew.com>
@esqew esqew changed the title Fixes pi-hole/AdminLTE#1796 Improvement to readability of footer "update" command text May 6, 2021
@PromoFaux PromoFaux merged commit dacb42d into pi-hole:devel May 7, 2021
@pralor-bot
Copy link

This pull request has been mentioned on Pi-hole Userspace. There might be relevant details there:

https://discourse.pi-hole.net/t/pi-hole-ftl-v5-9-web-v5-6-and-core-v5-4-released/49544/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants