Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use piholeStatus() in header.php #2062

Merged
merged 2 commits into from Jan 8, 2022
Merged

Use piholeStatus() in header.php #2062

merged 2 commits into from Jan 8, 2022

Conversation

yubiuser
Copy link
Member

@yubiuser yubiuser commented Jan 8, 2022

  • I have read and understood the contributors guide, as well as this entire template.
  • I have made only one major change in my proposed changes.
  • I have commented my proposed changes within the code.
  • I have tested my proposed changes.
  • I am willing to help maintain this change if there are issues with it later.
  • I give this submission freely and claim no ownership.
  • It is compatible with the EUPL 1.2 license
  • I have squashed any insignificant commits. (git rebase)
  • I have Signed Off all commits. (git commit --signoff)

What does this PR aim to accomplish?:

Follow up of #2059.
Re-uses piholeStatus() in header.php to avoid code duplication.

@yubiuser
Use piholeStatus() in header.php
97483dd 
Signed-off-by: Christian König <ckoenig@posteo.de>
@yubiuser yubiuser added the PR: Approval Required Open Pull Request, needs approval label Jan 8, 2022
@yubiuser
Remove check for null
8fb7c94 
Signed-off-by: Christian König <ckoenig@posteo.de>
@yubiuser yubiuser merged commit 9a5f62a into devel Jan 8, 2022
@yubiuser yubiuser deleted the function branch January 8, 2022 20:01
yubiuser added a commit that referenced this pull request Jan 11, 2022
@yubiuser
Use piholeStatus() in header.php (#2062)
d4415f2 
* Use piholeStatus() in header.php

Signed-off-by: Christian König <ckoenig@posteo.de>

* Remove check for null

Signed-off-by: Christian König <ckoenig@posteo.de>
@pralor-bot
Copy link

This pull request has been mentioned on Pi-hole Userspace. There might be relevant details there:

https://discourse.pi-hole.net/t/pi-hole-ftl-v5-14-web-v5-11-and-core-v5-9-released/53529/1

This was referenced Feb 12, 2022
Merged
Closed
Merged
Merged
@yubiuser yubiuser mentioned this pull request Feb 16, 2022
Closed
@renovate renovate bot mentioned this pull request Mar 5, 2022
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rdwebdesign rdwebdesign rdwebdesign approved these changes

Assignees
No one assigned
Labels
PR: Approval Required Open Pull Request, needs approval
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@yubiuser @pralor-bot @rdwebdesign