Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore api.php?summary response format #2067

Merged
merged 1 commit into from Jan 10, 2022
Merged

Restore api.php?summary response format #2067

merged 1 commit into from Jan 10, 2022

Conversation

rdwebdesign
Copy link
Member

By submitting this pull request, I confirm the following:

  • I have read and understood the contributors guide, as well as this entire template.
  • I have made only one major change in my proposed changes.
  • I have commented my proposed changes within the code.
  • I have tested my proposed changes.
  • I am willing to help maintain this change if there are issues with it later.
  • I give this submission freely and claim no ownership.
  • It is compatible with the EUPL 1.2 license
  • I have squashed any insignificant commits. (git rebase)
  • I have Signed Off all commits. (git commit --signoff)

What does this PR aim to accomplish?:

A recent modification in API changed the response format of api.php?summary.
This PR restores the old format.

How does this PR accomplish the above?:

Restoring the old functions only in "summary" response.
Note: calling the API using api.php?summaryRaw or api.php (without parameters) will return the new format.

What documentation changes (if any) are needed to support this PR?:

I don't know.
Maybe the differences between api.php?summary and api.php?summaryRaw should be more explicit.

restoring the old behavior

Signed-off-by: rdwebdesign <github@rdwebdesign.com.br>
@yubiuser yubiuser merged commit f0c3ecd into devel Jan 10, 2022
@yubiuser yubiuser deleted the fix_api_response branch January 10, 2022 18:23
yubiuser pushed a commit that referenced this pull request Jan 11, 2022
restoring the old behavior

Signed-off-by: rdwebdesign <github@rdwebdesign.com.br>
@yubiuser yubiuser linked an issue Jan 13, 2022 that may be closed by this pull request
@pralor-bot
Copy link

This pull request has been mentioned on Pi-hole Userspace. There might be relevant details there:

https://discourse.pi-hole.net/t/pi-hole-ftl-v5-14-web-v5-11-and-core-v5-9-released/53529/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

API: the 'summary' call now returns numbers instead of strings
3 participants