Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adjusting the notification icon #2095

Merged
merged 1 commit into from Jan 23, 2022
Merged

Adjusting the notification icon #2095

merged 1 commit into from Jan 23, 2022

Conversation

rdwebdesign
Copy link
Member

By submitting this pull request, I confirm the following:

  • I have read and understood the contributors guide, as well as this entire template.
  • I have made only one major change in my proposed changes.
  • I have commented my proposed changes within the code.
  • I have tested my proposed changes.
  • I am willing to help maintain this change if there are issues with it later.
  • I give this submission freely and claim no ownership.
  • It is compatible with the EUPL 1.2 license
  • I have squashed any insignificant commits. (git rebase)
  • I have Signed Off all commits. (git commit --signoff)

What does this PR aim to accomplish?:

  • Fixes the the triangle icon "overflow" (on mouse hover).
    Warning_triangle_hover

  • Adjust the icon size for better alignment.

  • Slightly change the timing and amplitude of the icon animation.

How does this PR accomplish the above?:

Adding (and changing) a few CSS properties.

What documentation changes (if any) are needed to support this PR?:

none

@rdwebdesign
Fix an "overflow" on hover
e8807fb 
Change the animation range and timing

Signed-off-by: rdwebdesign <github@rdwebdesign.com.br>
yubiuser
yubiuser approved these changes Jan 21, 2022
View reviewed changes
Copy link
Member

@yubiuser yubiuser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After the PR

Bildschirmfoto zu 2022-01-21 06-34-11

@rdwebdesign rdwebdesign merged commit a302e9f into devel Jan 23, 2022
@rdwebdesign rdwebdesign deleted the fix_warning_triangle branch January 23, 2022 21:24
@pralor-bot
Copy link

This pull request has been mentioned on Pi-hole Userspace. There might be relevant details there:

https://discourse.pi-hole.net/t/pi-hole-ftl-v5-14-web-v5-11-and-core-v5-9-released/53529/1

This was referenced Feb 12, 2022
Merged
Closed
Merged
Merged
@renovate renovate bot mentioned this pull request Mar 5, 2022
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yubiuser yubiuser yubiuser approved these changes

@DL6ER DL6ER Awaiting requested review from DL6ER

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@rdwebdesign @pralor-bot @yubiuser