Retreives maxlogage calling api_FTL.php #2107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yubiuser
reviewed
Feb 1, 2022
I did't know that. |
|
See the terminal output of the PR description of pi-hole/FTL#1295 But best would be to try different config settings and compare to the API output. |
|
You're right:
and API returns this second value (https://github.com/pi-hole/FTL/blob/development/src/api/api.c#L1499-L1503). |
FTL defines MAXLOGAGE value. PHP retrieves the value and converts seconds to hours Javascript calls the API to update the value. Signed-off-by: rdwebdesign <github@rdwebdesign.com.br>
rdwebdesign
force-pushed
the
maxlogage_via_API
branch
from
20ace3b
to
171bf81
Compare
yubiuser
approved these changes
Feb 2, 2022
|
This pull request has been mentioned on Pi-hole Userspace. There might be relevant details there: https://discourse.pi-hole.net/t/pi-hole-ftl-v5-14-web-v5-11-and-core-v5-9-released/53529/1 |
This was referenced Feb 12, 2022
Closed
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By submitting this pull request, I confirm the following:
git rebase)git commit --signoff)What does this PR aim to accomplish?:
Fixes #1825, even if the user compiles FTL with a custom MAXLOGAGE.
How does this PR accomplish the above?:
Javascript calls the API to update the title, using the FTL defined value.
What documentation changes (if any) are needed to support this PR?:
none.
PRE-REQUISITES:
This PR needs pi-hole/FTL#1295