Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add navigation above all datatables #2112

Merged
merged 1 commit into from Feb 6, 2022
Merged

Add navigation above all datatables #2112

merged 1 commit into from Feb 6, 2022

Conversation

yubiuser
Copy link
Member

@yubiuser yubiuser commented Feb 6, 2022

  • I have read and understood the contributors guide, as well as this entire template.
  • I have made only one major change in my proposed changes.
  • I have commented my proposed changes within the code.
  • I have tested my proposed changes.
  • I am willing to help maintain this change if there are issues with it later.
  • I give this submission freely and claim no ownership.
  • It is compatible with the EUPL 1.2 license
  • I have squashed any insignificant commits. (git rebase)
  • I have Signed Off all commits. (git commit --signoff)

What does this PR aim to accomplish?:

Adds the pagination navigation also above each data table. We had this for some tables already (e.g. Query log, network table). This PR adds this to all other tables

Discourse feature request: https://discourse.pi-hole.net/t/include-page-navigation-to-top-of-all-list-pages/53246

Bildschirmfoto zu 2022-02-06 21-48-58

Signed-off-by: Christian König <ckoenig@posteo.de>
@yubiuser yubiuser requested a review from a team February 6, 2022 20:51
@pralor-bot
Copy link

This pull request has been mentioned on Pi-hole Userspace. There might be relevant details there:

https://discourse.pi-hole.net/t/include-page-navigation-to-top-of-all-list-pages/53246/2

Copy link
Member

@rdwebdesign rdwebdesign left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree.
All tables should use the same configuration/visual whenever possible.

@yubiuser yubiuser merged commit 5005501 into devel Feb 6, 2022
@yubiuser yubiuser deleted the navigation branch February 6, 2022 21:04
@pralor-bot
Copy link

This pull request has been mentioned on Pi-hole Userspace. There might be relevant details there:

https://discourse.pi-hole.net/t/pi-hole-ftl-v5-14-web-v5-11-and-core-v5-9-released/53529/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants