New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove invalid PHP config file and change alert message for db_queries.js
#2113
Conversation
We need to change the docs here: https://docs.pi-hole.net/main/faq/#while-loading-data-from-the-long-term-database-you-encountered-an-error I wonder if we should decrease the default memory limit. We still support RPi 1, which has only 256 MB. The whole system might freeze if everything is taken by PHP. |
As far as I know, Raspberry Pis version 1 with 256 MB were discontinued a long time ago (from wikipedia).
|
Do you think the warning message should say something like that?
Or should we point to the docs page?
|
What happens if user change the limit and perform a Pi-hole update? Will the change be overwritten? |
db_queries.js
and change alert message for db_queries.js error. Signed-off-by: RD WebDesign <github@rdwebdesign.com.br>
8a51a95
to
66af9c5
Compare
The goal of this PR changed during the development. Due to merging #2114 the amount of memory Pi-hole uses when retrieving a huge amount of data from the long-term database is dramatically reduced. Therefore there is no reason to increase the memory by default. |
This pull request has been mentioned on Pi-hole Userspace. There might be relevant details there: https://discourse.pi-hole.net/t/pi-hole-ftl-v5-14-web-v5-11-and-core-v5-9-released/53529/1 |
By submitting this pull request, I confirm the following:
git rebase
)git commit --signoff
)What does this PR aim to accomplish?:
Remove unused
.user.php.ini
file.Change the message shown in
db_queries
page, when an unexpected error occurs.How does this PR accomplish the above?:
Deleting the file and adding a new message.
What documentation changes (if any) are needed to support this PR?:
None.