Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show "other" destination as the last graphic item #2189

Merged
merged 3 commits into from
Apr 26, 2022
Merged

Show "other" destination as the last graphic item #2189

merged 3 commits into from
Apr 26, 2022

Conversation

rdwebdesign
Copy link
Member

By submitting this pull request, I confirm the following:

  • I have read and understood the contributors guide, as well as this entire template.
  • I have made only one major change in my proposed changes.
  • I have commented my proposed changes within the code.
  • I have tested my proposed changes.
  • I am willing to help maintain this change if there are issues with it later.
  • I give this submission freely and claim no ownership.
  • It is compatible with the EUPL 1.2 license
  • I have squashed any insignificant commits. (git rebase)
  • I have Signed Off all commits. (git commit --signoff)

What does this PR aim to accomplish?:

Move the "other" destination to the last position on the graphic and legend.

Note:
The item will be shown only if it's different than zero.

How does this PR accomplish the above?:

Changing the javascript to move the item to last position.

What documentation changes (if any) are needed to support this PR?:

none

- Show the item only if it's different than zero

Signed-off-by: RD WebDesign <github@rdwebdesign.com.br>
Signed-off-by: RD WebDesign <github@rdwebdesign.com.br>
Signed-off-by: RD WebDesign <github@rdwebdesign.com.br>
@yubiuser yubiuser merged commit 67b63ff into devel Apr 26, 2022
@yubiuser yubiuser deleted the fix/other branch April 26, 2022 19:40
@yubiuser yubiuser linked an issue Apr 26, 2022 that may be closed by this pull request
@pralor-bot
Copy link

This pull request has been mentioned on Pi-hole Userspace. There might be relevant details there:

https://discourse.pi-hole.net/t/pi-hole-ftl-v5-16-web-v5-13-and-core-v5-11-1-released/56384/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upstream Servers Graph: "others" is not the last one (again)
3 participants