Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce border size of line charts #2198

Merged
merged 1 commit into from May 7, 2022
Merged

Reduce border size of line charts #2198

merged 1 commit into from May 7, 2022

Conversation

yubiuser
Copy link
Member

@yubiuser yubiuser commented May 2, 2022

  • I have read and understood the contributors guide, as well as this entire template.
  • I have made only one major change in my proposed changes.
  • I have commented my proposed changes within the code.
  • I have tested my proposed changes.
  • I am willing to help maintain this change if there are issues with it later.
  • I give this submission freely and claim no ownership.
  • It is compatible with the EUPL 1.2 license
  • I have squashed any insignificant commits. (git rebase)
  • I have Signed Off all commits. (git commit --signoff)

What does this PR aim to accomplish?:
It reduced the border width of the line charts (both at the dashboard as well as the long term graph). This is best seen at time points where no data is present. It looks like the y-Axis (zero line) is bold black, but indeed it is only the border of the graph lines sitting at zero.

Before:
Bildschirmfoto zu 2022-05-01 21-57-15

After:
Bildschirmfoto zu 2022-05-02 21-43-13

@yubiuser yubiuser requested a review from a team May 2, 2022 19:51
Signed-off-by: Christian König <ckoenig@posteo.de>
@rdwebdesign
Copy link
Member

rdwebdesign commented May 3, 2022

Did you test it with the light theme?

I think it's better, but the line is still visible.
pr2198

@yubiuser
Copy link
Member Author

yubiuser commented May 3, 2022

Yes, the border is still visible, but a lot less intrusive than before

Bildschirmfoto zu 2022-05-03 19-51-50

Bildschirmfoto zu 2022-05-03 19-56-43

@yubiuser yubiuser merged commit f8972ff into devel May 7, 2022
@yubiuser yubiuser deleted the zeroLineColor branch May 7, 2022 19:07
@pralor-bot
Copy link

This pull request has been mentioned on Pi-hole Userspace. There might be relevant details there:

https://discourse.pi-hole.net/t/pi-hole-ftl-v5-16-web-v5-13-and-core-v5-11-1-released/56384/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants