Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove duplicate function declarations #2201

Merged
merged 1 commit into from May 12, 2022
Merged

Conversation

rdwebdesign
Copy link
Member

@rdwebdesign rdwebdesign commented May 11, 2022

By submitting this pull request, I confirm the following:

  • I have read and understood the contributors guide, as well as this entire template.
  • I have made only one major change in my proposed changes.
  • I have commented my proposed changes within the code.
  • I have tested my proposed changes.
  • I am willing to help maintain this change if there are issues with it later.
  • I give this submission freely and claim no ownership.
  • It is compatible with the EUPL 1.2 license
  • I have squashed any insignificant commits. (git rebase)
  • I have Signed Off all commits. (git commit --signoff)

What does this PR aim to accomplish?:

The same functions were declared in multiple different files (outside func.php file) .
This PR remove unnecessary duplicate function declarations from individual files.

How does this PR accomplish the above?:

Moving the functions to func.php file.

What documentation changes (if any) are needed to support this PR?:

none

and move functions to `func.php`.

Signed-off-by: RD WebDesign <github@rdwebdesign.com.br>
@rdwebdesign rdwebdesign requested a review from a team May 11, 2022 21:32
@yubiuser yubiuser merged commit 0327e4f into devel May 12, 2022
@yubiuser yubiuser deleted the clean_duplicate_functions branch May 12, 2022 04:07
@pralor-bot
Copy link

This pull request has been mentioned on Pi-hole Userspace. There might be relevant details there:

https://discourse.pi-hole.net/t/pi-hole-ftl-v5-16-web-v5-13-and-core-v5-11-1-released/56384/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants