-
-
Notifications
You must be signed in to change notification settings - Fork 547
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add stickler-CI to test yaml and mkdown files #2238
Conversation
This repo needs to be enabled on |
Did we not already remove stickler at some point in the past? |
Searching for |
I think it is enabled now. |
Signed-off-by: Christian König <ckoenig@posteo.de>
Do you think we need to ignore "vendor" files? files:
ignore:
- '/scripts/vendor/*' |
It's not complaining now...but maybe does in the future? Shouldn't we report broken styling back to them if errors occur instead of ignoring the files? |
I don't think we should do this for external code. We can report upstream style issues if we found them, but I don't think this should block/delay a PR. |
Converted to draft until we figured out why files are not ignored and if we can fix this. |
Signed-off-by: Christian König <ckoenig@posteo.de>
The issue is fixed, files are ignored now as they should. |
This adds stickler-CI workflow to lint markdown and yaml files.
Uses https://pypi.org/project/yamllint/ and https://github.com/remarkjs/remark-lint internally