Show names in top clients list from long-term data

[yubiuser]

• What does this PR aim to accomplish?:

Replaces the IPs in the Top Clients list (in long-term data) with names if applicable. Since pi-hole/FTL#1255 we store more data in the long-term database, e.g. the name of the client which made the query. We can use that to fetch the name when generating the top list.

• How does this PR accomplish the above?:

Re-uses the code from #2202 to get the name of the client if one is set.

---

By submitting this pull request, I confirm the following:

1. I have read and understood the contributors guide, as well as this entire template. I understand which branch to base my commits and Pull Requests against.
2. I have commented my proposed changes within the code and I have tested my changes.
3. I am willing to help maintain this change if there are issues with it later.
4. It is compatible with the EUPL 1.2 license
5. I have squashed any insignificant commits. (git rebase)

---

• I have read the above and my PR is ready for review. Check this box to confirm

[pralor-bot]

This pull request has been mentioned on Pi-hole Userspace. There might be relevant details there:

https://discourse.pi-hole.net/t/top-clients-long-term-data/56325/7

[Bucking-Horn]

As this is about evaluating long term queries, does that cover for

• a client of the same name showing up with different IPs over time?
• the same IP being assigned or claimed by differently named hosts over time?

[rdwebdesign]

This is using client_by_id table.
(I'm not sure about the second item).

[yubiuser]

a client of the same name showing up with different IPs over time?

Our reference is still the IP. If a client (long discussion what a client is) changes IP, this will create a new entry in the client_by_id table and therefore show up as different client in the top list.

the same IP being assigned or claimed by differently named hosts over time

Again this will add a new entry in the database and show up as different client in the top list. The same happens if the client changes its name.

If the same IP/name combination is used by a different "real" client this will still be attributed to the same database client.
https://github.com/pi-hole/FTL/blob/ed35b17fe795b10006b789b7c09159a239dcd0e9/src/database/query-table.c#L169

[pralor-bot]

This pull request has been mentioned on Pi-hole Userspace. There might be relevant details there:

https://discourse.pi-hole.net/t/pi-hole-ftl-v5-16-web-v5-13-and-core-v5-11-1-released/56384/1

[pralor-bot]

This pull request has been mentioned on Pi-hole Userspace. There might be relevant details there:

https://discourse.pi-hole.net/t/resolve-client-ip-adresses-for-the-long-term-data-section/55655/2