Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the new "integrity check" option to debug log page #2259

Merged
merged 2 commits into from Jul 11, 2022
Merged

Conversation

rdwebdesign
Copy link
Member

Thank you for your contribution to the Pi-hole Community!

Please read the comments below to help us consider your Pull Request.

We are all volunteers and completing the process outlined will help us review your commits quicker.

Please make sure you

  1. Base your code and PRs against the repositories developmental branch.
  2. Sign Off all commits as we enforce the DCO for all contributions

  • What does this PR aim to accomplish?:

This PR adds the new "integrity check" option (created here) to the debug log page.

  • How does this PR accomplish the above?:

Adding a new checkbox and the related code.

  • What documentation changes (if any) are needed to support this PR?:

This option needs to be added to the Docs.


By submitting this pull request, I confirm the following:

  1. I have read and understood the contributors guide, as well as this entire template. I understand which branch to base my commits and Pull Requests against.
  2. I have commented my proposed changes within the code and I have tested my changes.
  3. I am willing to help maintain this change if there are issues with it later.
  4. It is compatible with the EUPL 1.2 license
  5. I have squashed any insignificant commits. (git rebase)

  • I have read the above and my PR is ready for review. Check this box to confirm

Signed-off-by: RD WebDesign <github@rdwebdesign.com.br>
@rdwebdesign rdwebdesign marked this pull request as draft July 10, 2022 21:50
Signed-off-by: RD WebDesign <github@rdwebdesign.com.br>
@rdwebdesign rdwebdesign marked this pull request as ready for review July 11, 2022 04:16
@rdwebdesign rdwebdesign requested review from yubiuser and a team July 11, 2022 04:17
Copy link
Member

@yubiuser yubiuser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bildschirmfoto zu 2022-07-11 18-30-27

@yubiuser yubiuser merged commit 122ff0e into devel Jul 11, 2022
@yubiuser yubiuser deleted the tweak/debug branch July 11, 2022 18:16
@yubiuser
Copy link
Member

This option needs to be added to the Docs.

☝️

@yubiuser yubiuser linked an issue Jul 14, 2022 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Debug log needs to allow the new option
2 participants