Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Specify record types at Local DNS records page #2273

Merged
merged 1 commit into from Jul 31, 2022
Merged

Specify record types at Local DNS records page #2273

merged 1 commit into from Jul 31, 2022

Conversation

yubiuser
Copy link
Member

  • What does this PR aim to accomplish?:

Small change on "Local DNS Records" to make it clear that both IPv4 and IPv6 addresses are supported.

Bildschirmfoto zu 2022-07-26 09-10-21

By submitting this pull request, I confirm the following:

  1. I have read and understood the contributors guide, as well as this entire template. I understand which branch to base my commits and Pull Requests against.
  2. I have commented my proposed changes within the code and I have tested my changes.
  3. I am willing to help maintain this change if there are issues with it later.
  4. It is compatible with the EUPL 1.2 license
  5. I have squashed any insignificant commits. (git rebase)
  • I have read the above and my PR is ready for review. Check this box to confirm

@yubiuser yubiuser requested a review from a team July 26, 2022 07:11
@yubiuser yubiuser added the PR: Approval Required Open Pull Request, needs approval label Jul 26, 2022
rdwebdesign
rdwebdesign previously approved these changes Jul 26, 2022
View reviewed changes
@yubiuser
Add A and AAAA to heading
38a7961 
Signed-off-by: Christian König <ckoenig@posteo.de>
@yubiuser
Copy link
Member Author

I changed to PR to only change the heading by appending [A/AAAA]

Bildschirmfoto zu 2022-07-31 12-26-26

@yubiuser yubiuser changed the title IPv4/IPv6 addresses on local DNS records Specify record types at Local DNS records page Jul 31, 2022
@yubiuser yubiuser requested a review from a team July 31, 2022 10:28
@yubiuser yubiuser merged commit e89dddf into devel Jul 31, 2022
@yubiuser yubiuser deleted the AAAA_DNS branch July 31, 2022 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rdwebdesign rdwebdesign rdwebdesign approved these changes

Assignees
No one assigned
Labels
PR: Approval Required Open Pull Request, needs approval
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@yubiuser @rdwebdesign