Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix PHP warninigs + Show Docker tag for nightly and dev #2330

Merged
merged 1 commit into from Sep 3, 2022
Merged

Fix PHP warninigs + Show Docker tag for nightly and dev #2330

merged 1 commit into from Sep 3, 2022

Conversation

rdwebdesign
Copy link
Member

What does this PR aim to accomplish?:

Fix #2328

How does this PR accomplish the above?:

  • Show the Docker tag for every image, including nightly and dev.
  • Always declare version strings, to avoid "Undefined variable" PHP warnings.

What documentation changes (if any) are needed to support this PR?:

none

By submitting this pull request, I confirm the following:

  1. I have read and understood the contributors guide, as well as this entire template. I understand which branch to base my commits and Pull Requests against.
  2. I have commented my proposed changes within the code and I have tested my changes.
  3. I am willing to help maintain this change if there are issues with it later.
  4. It is compatible with the EUPL 1.2 license
  5. I have squashed any insignificant commits. (git rebase)
  • I have read the above and my PR is ready for review. Check this box to confirm

@rdwebdesign
Declaring all strings to avoid warnings
b84c23e 
Signed-off-by: RD WebDesign <github@rdwebdesign.com.br>
@rdwebdesign rdwebdesign changed the title Declaring all strings to avoid warnings Fix PHP warninigs + Show Docker tag for nightly and dev Sep 3, 2022
@rdwebdesign rdwebdesign requested review from PromoFaux and a team September 3, 2022 20:28
@rdwebdesign rdwebdesign merged commit b0472ad into devel Sep 3, 2022
@rdwebdesign rdwebdesign deleted the footer_saga_end branch September 3, 2022 22:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yubiuser yubiuser yubiuser approved these changes

@PromoFaux PromoFaux Awaiting requested review from PromoFaux

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@rdwebdesign @yubiuser