Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set tooltip interaction mode for overtime graphs #2413

Merged
merged 3 commits into from Oct 23, 2022
Merged

Set tooltip interaction mode for overtime graphs #2413

merged 3 commits into from Oct 23, 2022

Conversation

yubiuser
Copy link
Member

What does this PR aim to accomplish?:

Fixes #2412.

When using the line graph style, multiple tooltips with partly doubled entries were shown for the same time slot. Setting the interaction mode to nearest (regarding the x-Axis) fixes the issue.


By submitting this pull request, I confirm the following:

  1. I have read and understood the contributors guide, as well as this entire template. I understand which branch to base my commits and Pull Requests against.
  2. I have commented my proposed changes within the code and I have tested my changes.
  3. I am willing to help maintain this change if there are issues with it later.
  4. It is compatible with the EUPL 1.2 license
  5. I have squashed any insignificant commits. (git rebase)

  • I have read the above and my PR is ready for review. Check this box to confirm

Signed-off-by: Christian König <ckoenig@posteo.de>
@yubiuser yubiuser added the PR: Approval Required Open Pull Request, needs approval label Oct 22, 2022
@yubiuser yubiuser requested a review from a team October 22, 2022 20:17
@yubiuser yubiuser linked an issue Oct 22, 2022 that may be closed by this pull request
@pralor-bot
Copy link

This pull request has been mentioned on Pi-hole Userspace. There might be relevant details there:

https://discourse.pi-hole.net/t/duplicate-data-on-dashboard/58721/29

Signed-off-by: Christian König <ckoenig@posteo.de>
Signed-off-by: Christian König <ckoenig@posteo.de>
@rdwebdesign
Copy link
Member

Looks fine on my test.

@yubiuser yubiuser added PR: Approved Open Pull Request, Approved by required number of reviewers and removed PR: Approval Required Open Pull Request, needs approval labels Oct 22, 2022
@yubiuser yubiuser merged commit aee9807 into devel Oct 23, 2022
@yubiuser yubiuser deleted the revert branch October 23, 2022 07:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: Approved Open Pull Request, Approved by required number of reviewers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Tracking] Line graphs show duplicated entries in tooltips in v5.16
3 participants