Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable spellcheckers from inspecting the password #2420

Merged
merged 1 commit into from Nov 11, 2022
Merged

Disable spellcheckers from inspecting the password #2420

merged 1 commit into from Nov 11, 2022

Conversation

adamatan
Copy link
Contributor

@adamatan adamatan commented Nov 7, 2022

What does this PR aim to accomplish?:

Prevent password leakage by spell checkers.

How does this PR accomplish the above?:

Adds an explicit spellcheck="false" attribute to the password field.


By submitting this pull request, I confirm the following:

  1. I have read and understood the contributors guide, as well as this entire template. I understand which branch to base my commits and Pull Requests against.
  2. I have commented my proposed changes within the code and I have tested my changes.
  3. I am willing to help maintain this change if there are issues with it later.
  4. It is compatible with the EUPL 1.2 license
  5. I have squashed any insignificant commits. (git rebase)
  6. I have checked that another pull request for this purpose does not exist.
  7. I have considered, and confirmed that this submission will be valuable to others.
  8. I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
  9. I give this submission freely, and claim no ownership to its content.

  • I have read the above and my PR is ready for review. Check this box to confirm

@yubiuser
Copy link
Member

yubiuser commented Nov 9, 2022

Thanks for your PR. Could you please rebase on latest devel?

Signed-off-by: Adam Matan <adam@matan.name>
@adamatan
Copy link
Contributor Author

Thanks @yubiuser , done.

@yubiuser yubiuser added PR: Approved Open Pull Request, Approved by required number of reviewers and removed Merge Conflicts Submitter Attention Required labels Nov 10, 2022
@yubiuser yubiuser merged commit 14d4493 into pi-hole:devel Nov 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: Approved Open Pull Request, Approved by required number of reviewers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants