Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update PHPStan #2450

Merged
merged 3 commits into from
Dec 8, 2022
Merged

Update PHPStan #2450

merged 3 commits into from
Dec 8, 2022

Conversation

yubiuser
Copy link
Member

@yubiuser yubiuser commented Dec 8, 2022

What does this PR aim to accomplish?:

We've been using phpstan natively in our github workflows. In order to make it work, we needed to set a fixed php version (introduced by #2007). This broke recently, as ubuntu-latest as GH runner updated to 22.04 which ships with php 8.1 instead of 8.0.
To avoid using updating the action with every new ubuntu release, I switched the workflow to use this phpstan action:
https://github.com/php-actions/phpstan

It will continue to use our configuration at phpstan.neon.dist. The optionexcludes_analyse is deprecated and replaced with excludePaths.

Side note: I updated the phpstan version in composer.json from ^0.12.42 to ^1*. The composer.lock is not updated yet, but I'll add composer as environment to dependabot so it should update this as well in the next run.


By submitting this pull request, I confirm the following:

  1. I have read and understood the contributors guide, as well as this entire template. I understand which branch to base my commits and Pull Requests against.
  2. I have commented my proposed changes within the code and I have tested my changes.
  3. I am willing to help maintain this change if there are issues with it later.
  4. It is compatible with the EUPL 1.2 license
  5. I have squashed any insignificant commits. (git rebase)
  6. I have checked that another pull request for this purpose does not exist.
  7. I have considered, and confirmed that this submission will be valuable to others.
  8. I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
  9. I give this submission freely, and claim no ownership to its content.

  • I have read the above and my PR is ready for review. Check this box to confirm

Signed-off-by: Christian König <ckoenig@posteo.de>
Signed-off-by: Christian König <ckoenig@posteo.de>
Signed-off-by: Christian König <ckoenig@posteo.de>
@yubiuser yubiuser requested a review from a team December 8, 2022 22:06
@yubiuser yubiuser added the PR: Approval Required Open Pull Request, needs approval label Dec 8, 2022
@rdwebdesign
Copy link
Member

The sudo update-alternatives for PHP was introduced an year ago to fix exactly the same issue, but with different versions.
At that time, using PHP 8.0 was the best choice, but this is not needed anymore.

@yubiuser yubiuser merged commit fa51e44 into devel Dec 8, 2022
@yubiuser yubiuser deleted the phpstan branch December 8, 2022 22:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal PR: Approval Required Open Pull Request, needs approval
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants