Adding option to show all results for queryads #2487
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rdwebdesign
force-pushed
the
queryads_all
branch
2 times, most recently
from
af647d6
to
3f026f7
Compare
rdwebdesign
added
the
PR: Code Review Required
yubiuser
requested changes
Jan 11, 2023
There was a problem hiding this comment.
It's not working. The URL construction fails at some place. When allis checked the URL looks like
http://pi.hole/admin/scripts/pi-hole/php/queryads.php?domain=flurry.com& but it should be http://pi.hole/admin/scripts/pi-hole/php/queryads.php?domain=flurry.com&showall
(The latter is working fine)
|
|
Signed-off-by: RD WebDesign <github@rdwebdesign.com.br>
Signed-off-by: RD WebDesign <github@rdwebdesign.com.br>
- "quiet" option and related functions (used by blocking page); - "adlist" option (used by blocking page). Signed-off-by: RD WebDesign <github@rdwebdesign.com.br>
rdwebdesign
force-pushed
the
queryads_all
branch
from
3f026f7
to
9c62cc5
Compare
Signed-off-by: RD WebDesign <github@rdwebdesign.com.br>
rdwebdesign
force-pushed
the
queryads_all
branch
from
ae6dd4d
to
839836d
Compare
yubiuser
approved these changes
Jan 13, 2023
rdwebdesign
removed
the
PR: Code Review Required
|
This pull request has been mentioned on Pi-hole Userspace. There might be relevant details there: https://discourse.pi-hole.net/t/pi-hole-ftl-v5-20-1-web-v5-18-1-and-core-v5-15-released/60495/1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR aim to accomplish?
Fix #2486
Allow unlimited results on the Tools > Search Adlists page.
Also change the message when more than 100 domains are returned.
How does this PR accomplish the above?
Adding code and a checkbox to allow unlimited results.
Link documentation PRs if any are needed to support this PR:
none
By submitting this pull request, I confirm the following:
git rebase)