Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add default value for $ver in func.php #2497

Merged
merged 1 commit into from Jan 17, 2023
Merged

Add default value for $ver in func.php #2497

merged 1 commit into from Jan 17, 2023

Conversation

yubiuser
Copy link
Member

What does this PR aim to accomplish?:

Sets a default value for $ver in func.php used to avoid browser cache issues. Fixes #2496


By submitting this pull request, I confirm the following:

  1. I have read and understood the contributors guide, as well as this entire template. I understand which branch to base my commits and Pull Requests against.
  2. I have commented my proposed changes within the code and I have tested my changes.
  3. I am willing to help maintain this change if there are issues with it later.
  4. It is compatible with the EUPL 1.2 license
  5. I have squashed any insignificant commits. (git rebase)
  6. I have checked that another pull request for this purpose does not exist.
  7. I have considered, and confirmed that this submission will be valuable to others.
  8. I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
  9. I give this submission freely, and claim no ownership to its content.

  • I have read the above and my PR is ready for review. Check this box to confirm

@yubiuser yubiuser added the PR: Approval Required Open Pull Request, needs approval label Jan 16, 2023
@yubiuser yubiuser requested a review from a team January 16, 2023 18:44
Copy link
Member

@rdwebdesign rdwebdesign left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This value can also be an empty string.
What do you think it's better?

Note:
this function will return this default value only if the file doesn't exist, but I think this will happen only if something is really broken, because the web interface should always have all files.

Signed-off-by: Christian König <ckoenig@posteo.de>

Co-authored-by: ElectronicsTinkerer <ElectronicsTinkerer@users.noreply.github.com>
@yubiuser
Copy link
Member Author

Mhh.. you are the web developer. I have no opinion on 0 vs ''. Both are fine for me.

@yubiuser yubiuser requested review from rdwebdesign and a team January 16, 2023 22:08
@rdwebdesign
Copy link
Member

rdwebdesign commented Jan 16, 2023

The question is almost stupid (it's just a preference):

What do you think is better to have in case of "file not found"?

    <link rel="stylesheet" href="style/pi-hole.css?v=0">
    or
    <link rel="stylesheet" href="style/pi-hole.css?v=">
    or something else
    <link rel="stylesheet" href="style/pi-hole.css?v=not_found">

Note:
I still don't know how a user can receive a file not found message from PHP, if AdminLTE ships all used files.

Copy link
Member

@PromoFaux PromoFaux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

0 is a fine default

image

@pralor-bot
Copy link

This pull request has been mentioned on Pi-hole Userspace. There might be relevant details there:

https://discourse.pi-hole.net/t/pi-hole-web-v5-18-2-and-core-v5-15-1-released/60695/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: Approval Required Open Pull Request, needs approval
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants