Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show two decimals on doughnutTooltip if total share shown is less than 1% #2502

Merged
merged 1 commit into from Jan 19, 2023

Conversation

yubiuser
Copy link
Member

What does this PR aim to accomplish?:

If users hide a big part of the doughnut chart, rounding can lead to "falsely" reported item share and confuse users. See #2500.

To compensate for that, this PR will show two decimal precision of each tooltip item when the total shown percentage is less then 1%

Screenshot at 2023-01-18 22-00-59


By submitting this pull request, I confirm the following:

  1. I have read and understood the contributors guide, as well as this entire template. I understand which branch to base my commits and Pull Requests against.
  2. I have commented my proposed changes within the code and I have tested my changes.
  3. I am willing to help maintain this change if there are issues with it later.
  4. It is compatible with the EUPL 1.2 license
  5. I have squashed any insignificant commits. (git rebase)
  6. I have checked that another pull request for this purpose does not exist.
  7. I have considered, and confirmed that this submission will be valuable to others.
  8. I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
  9. I give this submission freely, and claim no ownership to its content.

  • I have read the above and my PR is ready for review. Check this box to confirm

@yubiuser yubiuser requested a review from a team January 18, 2023 21:14
@yubiuser yubiuser linked an issue Jan 18, 2023 that may be closed by this pull request
@yubiuser yubiuser added the PR: Approval Required Open Pull Request, needs approval label Jan 18, 2023
…n 1%

Signed-off-by: Christian König <ckoenig@posteo.de>
@yubiuser
Copy link
Member Author

Has been confirmed working in #2500 (comment)

@yubiuser yubiuser merged commit 92a5154 into devel Jan 19, 2023
@yubiuser yubiuser deleted the double_precision branch January 19, 2023 20:50
@pralor-bot
Copy link

This pull request has been mentioned on Pi-hole Userspace. There might be relevant details there:

https://discourse.pi-hole.net/t/pi-hole-web-v5-18-2-and-core-v5-15-1-released/60695/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: Approval Required Open Pull Request, needs approval
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upstream donut: Low values strike yet again
3 participants