Hotfix v5.18.3 #2512
Merged
Hotfix v5.18.3 #2512
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: 4n4nk3 <47717886+4n4nk3@users.noreply.github.com>
Fix Improper Session Handling vulnerability of "Remember me for 7 days" functionality
|
Ah of course, the linter would not have run on the advisory PR... |
yubiuser
approved these changes
Jan 25, 2023
rdwebdesign
approved these changes
Jan 25, 2023
DL6ER
approved these changes
Jan 25, 2023
|
Just FYI: The Pi-hole v6.0 draft has something achieving the same (but differently) since almost two year. Here, we generate a random token for every successful login and assign a dedicated timeout to it (can be very long -> persistent login). In comparison to this realization, the v6.0 approach also takes the client IP address into account so "stealing" authentication from one device to another isn't possible. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.