Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose docker tag information using the API #2570

Merged
merged 1 commit into from Apr 8, 2023
Merged

Conversation

rdwebdesign
Copy link
Member

@rdwebdesign rdwebdesign commented Apr 3, 2023

What does this PR aim to accomplish?

Docker tag information is available since the introduction of versions file.
The docker info is shown by pihole -v and the web interface footer, but it was never added to the versions API endpoint.

How does this PR accomplish the above?

Adding the information to the API (only inside containers).

The new API response will look like this:

{
  "core_update": false,
  "web_update": false,
  "FTL_update": false,
  "docker_update": false,
  "core_current": "v5.16.2",
  "web_current": "v5.19",
  "FTL_current": "v5.22",
  "docker_current": "2023.03.1",
  "core_latest": "v5.16.2",
  "web_latest": "v5.19",
  "FTL_latest": "v5.22",
  "docker_latest": "2023.03.1",
  "core_branch": "master",
  "web_branch": "master",
  "FTL_branch": "master"
}

Link documentation PRs if any are needed to support this PR:

none


By submitting this pull request, I confirm the following:

  1. I have read and understood the contributors guide, as well as this entire template. I understand which branch to base my commits and Pull Requests against.
  2. I have commented my proposed changes within the code and I have tested my changes.
  3. I am willing to help maintain this change if there are issues with it later.
  4. It is compatible with the EUPL 1.2 license
  5. I have squashed any insignificant commits. (git rebase)
  6. I have checked that another pull request for this purpose does not exist.
  7. I have considered, and confirmed that this submission will be valuable to others.
  8. I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
  9. I give this submission freely, and claim no ownership to its content.

  • I have read the above and my PR is ready for review. Check this box to confirm

This information is available since the introduction of `versions` file.
Docker info is shown by `pihole -v` and the web interface footer, but
it was never added to the versions API.

Signed-off-by: RD WebDesign <github@rdwebdesign.com.br>
@rdwebdesign rdwebdesign requested a review from a team April 3, 2023 19:38
Copy link
Member

@yubiuser yubiuser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks fine. Could you add a sample output from one of your containers as comment or within the PR description?

@rdwebdesign
Copy link
Member Author

PR description updated.

@rdwebdesign rdwebdesign merged commit 8f95ec7 into devel Apr 8, 2023
15 checks passed
@rdwebdesign rdwebdesign deleted the show_docker_info_api branch April 8, 2023 04:18
@DL6ER DL6ER mentioned this pull request May 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants