-
-
Notifications
You must be signed in to change notification settings - Fork 549
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add progress reporting #2829
Add progress reporting #2829
Conversation
…r for (1) general page load, (2) login, and (3) saving settings Signed-off-by: DL6ER <dl6er@dl6er.de>
Signed-off-by: DL6ER <dl6er@dl6er.de>
I like it. It needs to be dynamic as the restarting times depend on the hardware used (and maybe even |
The settings toast needs to be rephrased to something more "in-progressy". I don't think we should remove it altogether (but we could as we have the overlay). |
No handholding. I forgot we added the 180 seconds at some point. I think the success toast should only fire after the progress animation finished, but at the same time. |
On finish we reload the page, I don't think there is a possibility for the toast to survive this |
…y 0.5 seconds (after an initial delay of 2 seconds) Signed-off-by: DL6ER <dl6er@dl6er.de>
The last commit should implement this without needing anything in addition from FTL. |
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
Signed-off-by: DL6ER <dl6er@dl6er.de>
Conflicts have been resolved. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a good change, I like that when saving settings input is blocked until the page has reloaded. Without this PR, I can very easily trigger errors by attempting to change a setting again too quickly after I have hit save & Apply
What does this implement/fix?
Add a processing overlay when saving settings and add general progress bar for
Example 1 (Login):
![ezgif-1-3e2f70a01a](https://private-user-images.githubusercontent.com/16748619/282723574-df963b53-3bf3-4f68-be33-4a4eb9e44ecf.gif?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjIzMTgxNjgsIm5iZiI6MTcyMjMxNzg2OCwicGF0aCI6Ii8xNjc0ODYxOS8yODI3MjM1NzQtZGY5NjNiNTMtM2JmMy00ZjY4LWJlMzMtNGE0ZWI5ZTQ0ZWNmLmdpZj9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA3MzAlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwNzMwVDA1Mzc0OFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTQwYzUyODRmZmE5ZTEwMWY1ZmZhN2M1ZTM5ZTdmZDdhNzhiMGFiYTFjYWYxN2I3ZjhiYWQxMzVmZjcxNWU1M2ImWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.M_nLkUFV78igEGsBNvjQHnBfjQGFTVjPwdECG21A4ig)
Example 2 (applying settings):
![ezgif-1-c42ee8e7be](https://private-user-images.githubusercontent.com/16748619/282723994-41d50dd1-c8fa-411b-b821-5ee5efbc369b.gif?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjIzMTgxNjgsIm5iZiI6MTcyMjMxNzg2OCwicGF0aCI6Ii8xNjc0ODYxOS8yODI3MjM5OTQtNDFkNTBkZDEtYzhmYS00MTFiLWI4MjEtNWVlNWVmYmMzNjliLmdpZj9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA3MzAlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwNzMwVDA1Mzc0OFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWJiMmU2MTcyMjRmOTZlYjI4ZDM0MTAyMjg3YTllNzUwNDRkNTY3OTA4ZDBmMDc5ZjQ4YzE1NDE4NjVkMDc4ZmQmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.k3wfBDPDsGk-IFPdv_R7NlnACgtNmJ6m9H8Q5Q4cOCc)
I would like to get some opinions: What is your general mood about this change? (in categories useless, hate it, like it, love it)
The timeout for the login is already dynamic (it takes as long as it takes) but the timeout for the settings is currently a hard-wired delay of 4 seconds (for demonstration purposes). We can make this dynamic by having FTL measure how long a restart really takes on a machine and sending this in the JSON response for using here.
Related issue or feature (if applicable): N/A
Pull request in docs with documentation (if applicable): N/A
By submitting this pull request, I confirm the following:
git rebase
)Checklist:
developmental
branch.