Set production dependencies in package.json #2855
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR aim to accomplish?:
We use some third-party
js
files we ship included with Pi-hole. So far, we updated them from time-to-time whenever we remembered them. As there was no "list" which dependencies we had and which version they are, we needed to look at eachjs
file or even went through the list of PRs.This PR tries to ease the update process by including all our shipped "production" dependencies in the node
package.json
where it will be picked up by dependebot which will inform us about new releases. This will not update the shippedjs
file but is a reminder for us to update the file manually.The only draw-back of this PR is that all the dependencies will be installed by the devcontainer and during the CI test even tough we won't need them. But I could not figure out a way to only install the
devDependencies
. (There once was--only=dev
but it was removed and not added back.)I included the versions of the dependencies as they are right now - some are a bit outdated which should be picked up by dependabot once this PR is merged.
By submitting this pull request, I confirm the following:
git rebase
)