Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set production dependencies in package.json #2855

Merged
merged 1 commit into from
Dec 5, 2023
Merged

Conversation

yubiuser
Copy link
Member

@yubiuser yubiuser commented Nov 19, 2023

What does this PR aim to accomplish?:

We use some third-party js files we ship included with Pi-hole. So far, we updated them from time-to-time whenever we remembered them. As there was no "list" which dependencies we had and which version they are, we needed to look at each js file or even went through the list of PRs.

This PR tries to ease the update process by including all our shipped "production" dependencies in the node package.json where it will be picked up by dependebot which will inform us about new releases. This will not update the shipped js file but is a reminder for us to update the file manually.

The only draw-back of this PR is that all the dependencies will be installed by the devcontainer and during the CI test even tough we won't need them. But I could not figure out a way to only install the devDependencies. (There once was --only=dev but it was removed and not added back.)

I included the versions of the dependencies as they are right now - some are a bit outdated which should be picked up by dependabot once this PR is merged.


By submitting this pull request, I confirm the following:

  1. I have read and understood the contributors guide, as well as this entire template. I understand which branch to base my commits and Pull Requests against.
  2. I have commented my proposed changes within the code and I have tested my changes.
  3. I am willing to help maintain this change if there are issues with it later.
  4. It is compatible with the EUPL 1.2 license
  5. I have squashed any insignificant commits. (git rebase)
  6. I have checked that another pull request for this purpose does not exist.
  7. I have considered, and confirmed that this submission will be valuable to others.
  8. I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
  9. I give this submission freely, and claim no ownership to its content.

  • I have read the above and my PR is ready for review. Check this box to confirm

Signed-off-by: Christian König <ckoenig@posteo.de>
@yubiuser yubiuser requested a review from a team November 19, 2023 19:22
Copy link
Member

@PromoFaux PromoFaux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like a good workaround (until we get to a point where we are shipping a compiled interface)

@yubiuser
Copy link
Member Author

yubiuser commented Dec 5, 2023

shipping a compiled interface

I already thought about this, but decided to postpone it until v7.

@yubiuser yubiuser merged commit c7671f6 into development-v6 Dec 5, 2023
6 checks passed
@yubiuser yubiuser deleted the dependencies branch December 5, 2023 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants