Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix legend crossing out #2872

Merged
merged 1 commit into from
Nov 25, 2023
Merged

Fix legend crossing out #2872

merged 1 commit into from
Nov 25, 2023

Conversation

DL6ER
Copy link
Member

@DL6ER DL6ER commented Nov 25, 2023

What does this implement/fix?

See title. Fixed by also checking item.hidden property when deciding to skip legend regeneration.

Example:

Screenshot from 2023-11-25 10-54-15

We can click on, e.g., A to hide A. Hiding the red chart area is working but the chart's legend is not updated:

Screenshot from 2023-11-25 10-54-50

This is fixed by this PR (see unticked box + crossed out text):

Screenshot from 2023-11-25 10-54-20

This was originally broken in 9c1f310 of #2811


Related issue or feature (if applicable): N/A

Pull request in docs with documentation (if applicable): N/A


By submitting this pull request, I confirm the following:

  1. I have read and understood the contributors guide, as well as this entire template. I understand which branch to base my commits and Pull Requests against.
  2. I have commented my proposed changes within the code.
  3. I am willing to help maintain this change if there are issues with it later.
  4. It is compatible with the EUPL 1.2 license
  5. I have squashed any insignificant commits. (git rebase)

Checklist:

  • The code change is tested and works locally.
  • I based my code and PRs against the repositories developmental branch.
  • I signed off all commits. Pi-hole enforces the DCO for all contributions
  • I signed all my commits. Pi-hole requires signatures to verify authorship
  • I have read the above and my PR is ready for review.

@DL6ER DL6ER merged commit 7d42606 into development-v6 Nov 25, 2023
7 checks passed
@DL6ER DL6ER deleted the fix/legend_crossed branch November 25, 2023 21:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants