Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert datatables upgrade #2874

Merged
merged 2 commits into from
Nov 26, 2023
Merged

Revert datatables upgrade #2874

merged 2 commits into from
Nov 26, 2023

Conversation

yubiuser
Copy link
Member

What does this PR aim to accomplish?:

Revert the datable update (PR #2852) but kept the commit that fixed the network table (1080019)

By submitting this pull request, I confirm the following:

  1. I have read and understood the contributors guide, as well as this entire template. I understand which branch to base my commits and Pull Requests against.
  2. I have commented my proposed changes within the code and I have tested my changes.
  3. I am willing to help maintain this change if there are issues with it later.
  4. It is compatible with the EUPL 1.2 license
  5. I have squashed any insignificant commits. (git rebase)
  6. I have checked that another pull request for this purpose does not exist.
  7. I have considered, and confirmed that this submission will be valuable to others.
  8. I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
  9. I give this submission freely, and claim no ownership to its content.
  • I have read the above and my PR is ready for review. Check this box to confirm

@yubiuser
Revert "Update datatables (#2852)"
c8a43d3 
This reverts commit e4ac12c, reversing
changes made to 54dba57.

Signed-off-by: Christian König <ckoenig@posteo.de>
@yubiuser
Fix datatable warning on network table
046c694 
Signed-off-by: Christian König <ckoenig@posteo.de>
@yubiuser yubiuser mentioned this pull request Nov 26, 2023
Closed
@yubiuser yubiuser linked an issue Nov 26, 2023 that may be closed by this pull request
After datatables update, tables are no longer striped #2867
Closed
@yubiuser yubiuser mentioned this pull request Nov 26, 2023
Merged
1 task
@yubiuser yubiuser marked this pull request as ready for review November 26, 2023 20:03
@DL6ER DL6ER changed the title Revert/datatables Revert datatables upgrade Nov 26, 2023
DL6ER
DL6ER approved these changes Nov 26, 2023
View reviewed changes
Copy link
Member

@DL6ER DL6ER left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, seems to do what it says

@yubiuser yubiuser merged commit 4ed958d into development-v6 Nov 26, 2023
9 checks passed
@yubiuser yubiuser deleted the revert/datatables branch November 26, 2023 21:00
This was referenced Dec 9, 2023
Closed
Closed
Closed
@yubiuser yubiuser mentioned this pull request Feb 10, 2024
Closed
This was referenced Mar 2, 2024
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DL6ER DL6ER DL6ER approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

After datatables update, tables are no longer striped
2 participants
@yubiuser @DL6ER