Fix a few invalid HTML elements generated by javascript #2875
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR aim to accomplish?
Fix invalid HTML code.
This code is generating an invalid HTML (lists cannot be inside a
<p>
tag):web/scripts/pi-hole/js/settings-advanced.js
Lines 14 to 20 in 4ed958d
The expected code would be:
But this is invalid. Most browser parsers will try to fix it and the final HTML code will be:
Also, we insert the generated code inside another
<p>
element.This is currently doing nothing (the empty paragraph just creates a small extra line in some cases), but if we add more elements to the functions, the generated code could break the layout.
How does this PR accomplish the above?
Fixing the javascript generating HTML and replacing a few
<p>
tags by<div>
tags (A<div>
element can be parent of<p>
and<ul>
elements).Reference:
Details explaining this behavior can be found on the last Note of the 4.4.1 section:
By submitting this pull request, I confirm the following:
git rebase
)