Add some tolerance to the autoscrolling feature of taillog #2879
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this implement/fix?
On initial load of the taillog page, the "autoscroll" feature is enabled so you will always see the most recent log events. If something catches you attention you can stop this by simply scrolling a bit up. You can then re-enable autoscroll by scrolling again down to the very bottom.
So far, so good. This seems to work reasonably well. however, you have to scroll down all the way because the textbox must be at the exact bottom for autoscrolling to be re-enabled. This PR improves this behavior by adding a tolerance of four line heights for autoscrolling to be re-engage.
This PR is correlated to this Discourse post (German).
Related issue or feature (if applicable): N/A
Pull request in docs with documentation (if applicable): N/A
By submitting this pull request, I confirm the following:
git rebase
)Checklist:
developmental
branch.