Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add some tolerance to the autoscrolling feature of taillog #2879

Merged
merged 1 commit into from
Nov 30, 2023

Conversation

DL6ER
Copy link
Member

@DL6ER DL6ER commented Nov 28, 2023

What does this implement/fix?

On initial load of the taillog page, the "autoscroll" feature is enabled so you will always see the most recent log events. If something catches you attention you can stop this by simply scrolling a bit up. You can then re-enable autoscroll by scrolling again down to the very bottom.

So far, so good. This seems to work reasonably well. however, you have to scroll down all the way because the textbox must be at the exact bottom for autoscrolling to be re-enabled. This PR improves this behavior by adding a tolerance of four line heights for autoscrolling to be re-engage.

This PR is correlated to this Discourse post (German).


Related issue or feature (if applicable): N/A

Pull request in docs with documentation (if applicable): N/A


By submitting this pull request, I confirm the following:

  1. I have read and understood the contributors guide, as well as this entire template. I understand which branch to base my commits and Pull Requests against.
  2. I have commented my proposed changes within the code.
  3. I am willing to help maintain this change if there are issues with it later.
  4. It is compatible with the EUPL 1.2 license
  5. I have squashed any insignificant commits. (git rebase)

Checklist:

  • The code change is tested and works locally.
  • I based my code and PRs against the repositories developmental branch.
  • I signed off all commits. Pi-hole enforces the DCO for all contributions
  • I signed all my commits. Pi-hole requires signatures to verify authorship
  • I have read the above and my PR is ready for review.

Signed-off-by: DL6ER <dl6er@dl6er.de>
@DL6ER DL6ER requested a review from a team November 28, 2023 21:50
@DL6ER
Copy link
Member Author

DL6ER commented Nov 29, 2023

Confirmed to be working on Discourse

Copy link
Member

@yubiuser yubiuser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding a detailed comment section.

@DL6ER DL6ER merged commit 0de9342 into development-v6 Nov 30, 2023
7 checks passed
@DL6ER DL6ER deleted the tweak/autoscroll_tolerance branch November 30, 2023 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants