Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add live Query Log feature #2880

Merged
merged 3 commits into from Dec 1, 2023
Merged

Add live Query Log feature #2880

merged 3 commits into from Dec 1, 2023

Conversation

DL6ER
Copy link
Member

@DL6ER DL6ER commented Nov 28, 2023

What does this implement/fix?

This PR adds a checkbox for enabling/disabling live Query Log updates.

Screenshot from 2023-11-28 23-52-50

This enhancement improves the user experience by providing more flexibility in how the recent queries are displayed and updated.

Related issue or feature (if applicable): N/A

Pull request in docs with documentation (if applicable): N/A


By submitting this pull request, I confirm the following:

  1. I have read and understood the contributors guide, as well as this entire template. I understand which branch to base my commits and Pull Requests against.
  2. I have commented my proposed changes within the code.
  3. I am willing to help maintain this change if there are issues with it later.
  4. It is compatible with the EUPL 1.2 license
  5. I have squashed any insignificant commits. (git rebase)

Checklist:

  • The code change is tested and works locally.
  • I based my code and PRs against the repositories developmental branch.
  • I signed off all commits. Pi-hole enforces the DCO for all contributions
  • I signed all my commits. Pi-hole requires signatures to verify authorship
  • I have read the above and my PR is ready for review.

Signed-off-by: DL6ER <dl6er@dl6er.de>
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

Copy link
Member

@yubiuser yubiuser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the option "live" mode should be disabled when "Query on-disk-data" is enabled. I got inconsistent results: sometime it was working, sometimes not and once it produced an SQL error.

@DL6ER
Copy link
Member Author

DL6ER commented Nov 30, 2023

Do you have a log excerpt for the SQL error?

@yubiuser
Copy link
Member

That's all I got

2023-11-30 21:50:15.204 [42661/T42832] ERR: SQLite3 message: statement aborts at 4: [ATTACH ? AS ?] database disk is already in use (1)
2023-11-30 21:50:15.204 [42661/T42832] ERR: attach_database(): Failed to attach database: SQL logic error
2023-11-30 21:50:15.204 [42661/T42832] WARNING: API: Internal server error, cannot attach disk database (SQL logic error)

Maybe because my device is slow but I clicked fast.

Signed-off-by: DL6ER <dl6er@dl6er.de>
Signed-off-by: DL6ER <dl6er@dl6er.de>
Copy link
Contributor

Conflicts have been resolved.

@DL6ER DL6ER requested a review from yubiuser November 30, 2023 21:12
@DL6ER DL6ER merged commit 42f29b2 into development-v6 Dec 1, 2023
8 checks passed
@DL6ER DL6ER deleted the new/live_query_log branch December 1, 2023 06:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants