Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change regex link text to entry #2894

Merged
merged 2 commits into from
Dec 13, 2023
Merged

Change regex link text to entry #2894

merged 2 commits into from
Dec 13, 2023

Conversation

yubiuser
Copy link
Member

@yubiuser yubiuser commented Dec 8, 2023

What does this PR aim to accomplish?:

Simple text change. We do not only link back from query log to regex, but to all manually configured domains.

Example:
Screenshot at 2023-12-08 21-38-13
Screenshot at 2023-12-08 21-38-29


By submitting this pull request, I confirm the following:

  1. I have read and understood the contributors guide, as well as this entire template. I understand which branch to base my commits and Pull Requests against.
  2. I have commented my proposed changes within the code and I have tested my changes.
  3. I am willing to help maintain this change if there are issues with it later.
  4. It is compatible with the EUPL 1.2 license
  5. I have squashed any insignificant commits. (git rebase)
  6. I have checked that another pull request for this purpose does not exist.
  7. I have considered, and confirmed that this submission will be valuable to others.
  8. I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
  9. I give this submission freely, and claim no ownership to its content.

  • I have read the above and my PR is ready for review. Check this box to confirm

Signed-off-by: Christian König <ckoenig@posteo.de>
@yubiuser yubiuser requested a review from a team December 8, 2023 20:39
Co-authored-by: RD WebDesign <github@rdwebdesign.com.br>
Signed-off-by: yubiuser <ckoenig@posteo.de>
@yubiuser yubiuser changed the title Change regex link text to domain Change regex link text to entry Dec 9, 2023
Copy link
Member

@DL6ER DL6ER left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't actually show the database ID on the target is this link.

How about not showing the ID at all? Instead of "entry with ID" we show "allowlist" or "denylist" (depending on what is appropriate)

@rdwebdesign
Copy link
Member

We actually show the ID in the tooltip:

x

@yubiuser
Copy link
Member Author

Instead of "entry with ID" we show "allowlist" or "denylist" (depending on what is appropriate)

This would lead to some kind of doubeling:

"Query was allowed by allowlist" and "Query was denied by denylist".

@rdwebdesign
Copy link
Member

Personally, I don't think it's an issue to use the ID on the link.

@yubiuser yubiuser merged commit 2889bb5 into development-v6 Dec 13, 2023
8 checks passed
@yubiuser yubiuser deleted the domain_link branch December 13, 2023 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants