Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add query log handling of SPECIAL_DOMAIN #2895

Merged
merged 2 commits into from
Jan 11, 2024
Merged

Conversation

yubiuser
Copy link
Member

@yubiuser yubiuser commented Dec 8, 2023

What does this PR aim to accomplish?:

Add query log handling of special domains (mozilla canary domain, apple icloud private relay).

Before
Screenshot at 2023-12-08 21-42-01

After
Screenshot at 2023-12-08 21-45-02


By submitting this pull request, I confirm the following:

  1. I have read and understood the contributors guide, as well as this entire template. I understand which branch to base my commits and Pull Requests against.
  2. I have commented my proposed changes within the code and I have tested my changes.
  3. I am willing to help maintain this change if there are issues with it later.
  4. It is compatible with the EUPL 1.2 license
  5. I have squashed any insignificant commits. (git rebase)
  6. I have checked that another pull request for this purpose does not exist.
  7. I have considered, and confirmed that this submission will be valuable to others.
  8. I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
  9. I give this submission freely, and claim no ownership to its content.

  • I have read the above and my PR is ready for review. Check this box to confirm

@yubiuser yubiuser requested a review from a team December 8, 2023 20:48
Signed-off-by: Christian König <ckoenig@posteo.de>
scripts/pi-hole/js/queries.js Outdated Show resolved Hide resolved
Co-authored-by: RD WebDesign <github@rdwebdesign.com.br>
Signed-off-by: yubiuser <ckoenig@posteo.de>
@yubiuser yubiuser merged commit 7e21b3b into development-v6 Jan 11, 2024
8 checks passed
@yubiuser yubiuser deleted the SPECIAL_DOMAIN branch January 11, 2024 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants